Review main Merged

48393[TASK] Limit request to get logout information

Nicole Hummel CR +2 V +2 Easy +18 −5 updated 08/31/16, 15:05

Commit message

Currently a request to get information about the login state is
triggered every minute. To prevent traffic the request can be triggered
only when the session is about to expire. This patch adds a function
to be able to pass the interval time to the LoginRefresh refresh and
sets it properly after initialization.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Helmut Hummel +1
    • Philipp Gampe +1
  • Verified V +2
    • Stefan Neufeind +2
    • Philipp Gampe +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2528

Show 3 earlier messages
  1. Nicole Hummel uploaded patch set 1 05/29/16, 13:50

  2. Markus Klein uploaded patch set 2 05/29/16, 15:21

  3. Nicole Hummel updated the commit message in patch set 3 05/29/16, 15:27

  1. Markus Klein voted on patch set 3 CR +1 V +1 05/29/16, 15:33

  2. Wouter Wolters commented on patch set 3 05/29/16, 19:30

    marked as feature, can't go in 7.6. This will lead to questions.. Mark it as task maybe?
  3. Markus Klein commented on patch set 3 05/29/16, 22:13

    Oh, right... totally overlooked that. Nicole, why a feature? (I would this even call a bugfix, since "unnecessary requests" are a bug actually. ;-) )
  4. Frank Nägler commented on patch set 3 05/30/16, 09:43

    BackendController.php:130

    some month ago, we wanted use the session timeout in JavaScript and add it to the backend JavaScript config. the patch was rejected, because expose the session timeout is insecure (information disclosure). now this patch will also expose the session timeout. I can't find the patch, but I am sure this was the reason.
  5. Nicole Hummel updated the commit message in patch set 4 08/29/16, 10:07

  6. TYPO3com voted on patch set 4 V +1 08/29/16, 10:11 Completed build in 03m 19s on Mon, 29 Aug, 12:11 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2389

  7. Stefan Neufeind uploaded patch set 5 08/29/16, 10:22

  8. Stefan Neufeind commented on patch set 5 08/29/16, 10:23

    manually resolved merge-conflict
  9. TYPO3com voted on patch set 5 V +1 08/29/16, 10:25 Completed build in 02m 41s on Mon, 29 Aug, 12:25 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2392

  10. Stefan Neufeind commented on patch set 5 CR +1 08/29/16, 15:01

    LoginRefresh.js:468

    in case some update for this is pushed maybe drop the space behind "function"
  11. Stefan Neufeind commented on patch set 5 CR 0 08/29/16, 15:03

    I wonder if somebody else might rely on timestamps being updated (one every minute or so) to see which BE-users are still "active" ...
  12. Nicole Hummel commented on patch set 5 08/29/16, 15:26

    @Stefan: That would be broken as the session is still valid even if not updated within one minute.
  13. Andreas Kienast voted on patch set 5 CR +1 08/29/16, 15:37

  14. Stefan Neufeind voted on patch set 5 CR +1 08/29/16, 15:45

  15. Philipp Gampe commented on patch set 5 08/29/16, 20:26

    What about Franks question? (Patchset 3)
  16. Helmut Hummel commented on patch set 5 08/29/16, 21:01

    I don't see a security risk in the fact that a logged in backend user can see the session timeout config in the generated HTML. I can't imagine any possible attack vector, which uses this information.
  17. Helmut Hummel voted on patch set 5 CR +1 08/29/16, 21:01

  18. Benni Mack commented on patch set 6 08/30/16, 11:17

    Published edit on patch set 5.
  19. TYPO3com voted on patch set 6 V +1 08/30/16, 11:20 Completed build in 02m 48s on Tue, 30 Aug, 01:20 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2430

  20. Helmut Hummel voted on patch set 6 CR +1 08/30/16, 11:21

  21. Stefan Neufeind voted on patch set 6 CR +1 08/30/16, 12:51

  22. Philipp Gampe voted on patch set 6 CR +1 V +1 08/31/16, 14:54

  23. Stefan Neufeind voted on patch set 6 CR +2 V +2 08/31/16, 15:04

  24. Gerrit merged patch set 6 08/31/16, 15:04

  25. Stefan Neufeind commented on patch set 7 08/31/16, 15:05

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit ec781baf663d0d7bdeda084b507c10fc2838c7c0