Review main Merged

48394[TASK] Automatically select the custom preset when values are changed

Markus Klein CR +2 V +2 Easy +13 −5 updated 05/31/16, 06:13

Commit message

If the user changes a field in a custom preset in the Install Tool
the custom preset's radio box must be selected too.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Wouter Wolters +1
  • Verified V +2
    • Frank Nägler +2
    • Wouter Wolters +1

Issues 1

Files 4

Review log 16

  1. Markus Klein uploaded patch set 1 05/29/16, 13:59

  2. Markus Klein updated the commit message in patch set 2 05/29/16, 14:15

  3. Markus Klein wrote 05/29/16, 14:38

    Topic set to Install Tool
  4. Markus Klein commented on patch set 3 05/29/16, 14:43

    Published edit on patch set 2.
  5. Wouter Wolters voted on patch set 3 CR +1 V +1 05/29/16, 19:27

  6. Christian Kuhn commented on patch set 3 05/29/16, 21:48

    -1 for 6.2, this is an admin related ux improvement. clearly not a critical bug fix for 6.2 anymore.
  7. Frank Nägler commented on patch set 3 CR +1 V +1 05/30/16, 09:54

    really down to 6.2?
  8. Christian Kuhn updated the commit message in patch set 4 05/30/16, 12:38

  9. Christian Kuhn commented on patch set 4 05/30/16, 12:38

    removed 6.2 after ok from nicole.
  10. Wouter Wolters voted on patch set 4 CR +1 V +1 05/30/16, 12:42

  11. Frank Nägler voted on patch set 4 CR +2 V +2 05/30/16, 13:43

  12. Gerrit merged patch set 4 05/30/16, 13:43

  13. Nicole Hummel commented on patch set 5 05/30/16, 19:47

    Just to be sure. I have to change the focus to get a selected "Custom configuration". Is this intended to work like that? Because commit message says "user changes the field"
  14. Helmut Hummel commented on patch set 5 05/30/16, 20:08

    wouldn't it make much more sense to hide all input fields unless the radio box for "custom" is selected?
  15. Nicole Hummel commented on patch set 5 05/30/16, 20:56

  16. Markus Klein commented on patch set 5 05/31/16, 06:13

    No it does not IMO. Having all options visible right away help to get an overview and it also saves one click, which would be required otherwise to unfold the options.