48396[TASK] Automatically select the custom preset when values are changed
Commit message
Review
-
Code review CR +2
- Nicole Hummel +2
- Wouter Wolters +1
- Frank Nägler +1
-
Verified V +2
- Nicole Hummel +2
- Wouter Wolters +1
Issues 1
Files 5
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Configuration/Charset/Custom.html+3 −2
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Configuration/Context/Custom.html+2 −1
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Configuration/Image/Custom.html+2 −1
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Configuration/Mail/Custom.html+4 −3
- typo3/sysext/install/Resources/Public/JavaScript/Install.js3+5 −0
Review log 25
-
Markus Klein uploaded patch set 1 05/29/16, 14:12
-
Markus Klein updated the commit message in patch set 2 05/29/16, 14:15
-
Markus Klein wrote 05/29/16, 14:38
Topic set to Install Tool -
Markus Klein commented on patch set 3 05/29/16, 14:42
Published edit on patch set 2. -
Markus Klein commented on patch set 4 05/29/16, 14:43
Published edit on patch set 3. -
Wouter Wolters voted on patch set 4 CR +1 V +1 05/29/16, 19:27
-
Nicole Hummel commented on patch set 4 CR -2 05/30/16, 12:35
Please wait until master is merged -
Christian Kuhn updated the commit message in patch set 5 05/30/16, 12:39
-
Frank Nägler voted on patch set 5 CR +1 V +1 05/30/16, 13:44
-
Wouter Wolters voted on patch set 5 CR +1 V +1 05/30/16, 13:45
-
Helmut Hummel commented on patch set 5 05/30/16, 20:09
wouldn't it make much more sense to hide all input fields unless the radio box for "custom" is selected? -
Markus Klein commented on patch set 5 05/31/16, 06:12
I actually prefer the way it is now. You save one click and all options are visible right away -
Nicole Hummel uploaded patch set 6 06/03/16, 09:51
-
Nicole Hummel voted on patch set 6 CR +1 V +1 06/03/16, 09:54
-
Nicole Hummel uploaded patch set 7 06/03/16, 10:43
-
Nicole Hummel commented on patch set 7 CR +1 V +1 06/03/16, 10:44
Added an js event for IE 8 -
Wouter Wolters voted on patch set 7 CR +1 06/03/16, 10:46
-
Frank Nägler commented on patch set 7 CR -1 06/03/16, 11:26
Install.js:680since CMS 7.6 we support IE >= 9 the oninput event is supoorted since IE9, so no need for this event. -
Markus Klein commented on patch set 7 06/03/16, 11:29
Install.js:680ReplyEhm... this is not because of IE, but because we have checkboxes in the mail preset, which need to trigger that too. and those to not trigger oninput! -
Frank Nägler commented on patch set 7 06/03/16, 12:01
Install.js:680Replycomment by Nicole was: Added an js event for IE 8 And as discussed today in slack, we have no checkboxes which trigger the event. So from my point of view, this event is not needed and should be removed. @Nicole: Any other reason for this event? -
Wouter Wolters commented on patch set 8 06/04/16, 11:39
Published edit on patch set 7. -
Wouter Wolters commented on patch set 8 CR +1 V +1 06/04/16, 11:40
That was my fault I thought version 7 had IE8 as lowest version. I checked now and this is IE9. All good with default on input. -
Frank Nägler voted on patch set 8 CR +1 06/04/16, 11:51
-
Nicole Hummel voted on patch set 8 CR +2 V +2 06/06/16, 12:09
-
Gerrit merged patch set 8 06/06/16, 12:09