Review TYPO3_7-6 Merged

48396[TASK] Automatically select the custom preset when values are changed

Markus Klein CR +2 V +2 Easy +16 −7 updated 06/06/16, 12:09

Commit message

If the user changes a field in a custom preset in the Install Tool
the custom preset's radio box must be selected too.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Wouter Wolters +1
    • Frank Nägler +1
  • Verified V +2
    • Nicole Hummel +2
    • Wouter Wolters +1

Issues 1

Files 5

Review log 25

  1. Markus Klein uploaded patch set 1 05/29/16, 14:12

  2. Markus Klein updated the commit message in patch set 2 05/29/16, 14:15

  3. Markus Klein wrote 05/29/16, 14:38

    Topic set to Install Tool
  4. Markus Klein commented on patch set 3 05/29/16, 14:42

    Published edit on patch set 2.
  5. Markus Klein commented on patch set 4 05/29/16, 14:43

    Published edit on patch set 3.
  6. Wouter Wolters voted on patch set 4 CR +1 V +1 05/29/16, 19:27

  7. Nicole Hummel commented on patch set 4 CR -2 05/30/16, 12:35

    Please wait until master is merged
  8. Christian Kuhn updated the commit message in patch set 5 05/30/16, 12:39

  9. Frank Nägler voted on patch set 5 CR +1 V +1 05/30/16, 13:44

  10. Wouter Wolters voted on patch set 5 CR +1 V +1 05/30/16, 13:45

  11. Helmut Hummel commented on patch set 5 05/30/16, 20:09

    wouldn't it make much more sense to hide all input fields unless the radio box for "custom" is selected?
  12. Markus Klein commented on patch set 5 05/31/16, 06:12

    I actually prefer the way it is now. You save one click and all options are visible right away
  13. Nicole Hummel uploaded patch set 6 06/03/16, 09:51

  14. Nicole Hummel voted on patch set 6 CR +1 V +1 06/03/16, 09:54

  15. Nicole Hummel uploaded patch set 7 06/03/16, 10:43

  16. Nicole Hummel commented on patch set 7 CR +1 V +1 06/03/16, 10:44

    Added an js event for IE 8
  17. Wouter Wolters voted on patch set 7 CR +1 06/03/16, 10:46

  18. Frank Nägler commented on patch set 7 CR -1 06/03/16, 11:26

    Install.js:680

    since CMS 7.6 we support IE >= 9 the oninput event is supoorted since IE9, so no need for this event.
  19. Markus Klein commented on patch set 7 06/03/16, 11:29

    Install.js:680 Reply

    Ehm... this is not because of IE, but because we have checkboxes in the mail preset, which need to trigger that too. and those to not trigger oninput!
  20. Frank Nägler commented on patch set 7 06/03/16, 12:01

    Install.js:680 Reply

    comment by Nicole was: Added an js event for IE 8 And as discussed today in slack, we have no checkboxes which trigger the event. So from my point of view, this event is not needed and should be removed. @Nicole: Any other reason for this event?
  21. Wouter Wolters commented on patch set 8 06/04/16, 11:39

    Published edit on patch set 7.
  22. Wouter Wolters commented on patch set 8 CR +1 V +1 06/04/16, 11:40

    That was my fault I thought version 7 had IE8 as lowest version. I checked now and this is IE9. All good with default on input.
  23. Frank Nägler voted on patch set 8 CR +1 06/04/16, 11:51

  24. Nicole Hummel voted on patch set 8 CR +2 V +2 06/06/16, 12:09

  25. Gerrit merged patch set 8 06/06/16, 12:09