48398[BUGFIX] Fix output of DebugUtility
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Wouter Wolters +1
-
Verified V +2
- Helmut Hummel +2
Issues 1
Files 4
Review log 8
-
Helmut Hummel uploaded patch set 1 05/29/16, 17:01
-
Markus Klein commented on patch set 1 06/06/16, 00:07
-
Jan Runte commented on patch set 1 CR +1 06/06/16, 18:43
ContentObjectRendererTest.php:3036You can optimize your str_replace function with using arrays as arguments. $cleanedResult = str_replace(["\n", "\r", "\t", ' '], '', $result); -
Helmut Hummel uploaded patch set 2 06/07/16, 06:51
-
Helmut Hummel commented on patch set 1 06/07/16, 08:06
ContentObjectRendererTest.php:3036Replytrue, but this is a backport and should stay similar to master. Please push a cleanup patch to master, thanks. -
Wouter Wolters voted on patch set 2 CR +1 06/08/16, 10:24
-
Helmut Hummel voted on patch set 2 CR +2 V +2 06/08/16, 10:36
-
Gerrit merged patch set 2 06/08/16, 10:36
DebugUtility.php:31