Review TYPO3_7-6 Merged

48398[BUGFIX] Fix output of DebugUtility

Helmut Hummel CR +2 V +2 Hard +216 −37 updated 06/08/16, 10:36

Commit message

This change prettifies the output of the debug output
methods, by using the Extbase DebuggerUtility for that purpose.

The benefits are consistent, well readable, properly encoded output
for every case the class provides.

In the long run, this class should be replaced with
a more object oriented approach.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Wouter Wolters +1
  • Verified V +2
    • Helmut Hummel +2

Issues 1

Files 4

Review log 8

  1. Helmut Hummel uploaded patch set 1 05/29/16, 17:01

  2. Markus Klein commented on patch set 1 06/06/16, 00:07

    DebugUtility.php:31

    Reading this again I just realized that according to PSR-2 these modifies must be switched. This is also wrong in the master patch. I propose to fix it here and let it be fixed for master by the automated CS fixer runs done once in a while.
  3. Jan Runte commented on patch set 1 CR +1 06/06/16, 18:43

    ContentObjectRendererTest.php:3036

    You can optimize your str_replace function with using arrays as arguments. $cleanedResult = str_replace(["\n", "\r", "\t", ' '], '', $result);
  4. Helmut Hummel uploaded patch set 2 06/07/16, 06:51

  5. Helmut Hummel commented on patch set 1 06/07/16, 08:06

    ContentObjectRendererTest.php:3036 Reply

    true, but this is a backport and should stay similar to master. Please push a cleanup patch to master, thanks.
  6. Wouter Wolters voted on patch set 2 CR +1 06/08/16, 10:24

  7. Helmut Hummel voted on patch set 2 CR +2 V +2 06/08/16, 10:36

  8. Gerrit merged patch set 2 06/08/16, 10:36