48400[TASK] Upgrade to phpunit 5.3
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Wouter Wolters +1
- Mathias Brodala +1
-
Verified V +2
- Frank Nägler +2
- Wouter Wolters +1
Issues 1
Files 2
Review log 9
-
Christian Kuhn uploaded patch set 1 05/30/16, 10:07
-
Christian Kuhn commented on patch set 1 05/30/16, 10:09
catharsis: https://travis-ci.org/lolli42/TYPO3.CMS-Catharsis/builds/133881365 -
Wouter Wolters voted on patch set 1 CR +1 V +1 05/30/16, 10:25
-
Mathias Brodala commented on patch set 1 CR -1 05/30/16, 10:38
composer.json:55How about ^5.3.0 instead to simplify future updates? -
Christian Kuhn commented on patch set 1 05/30/16, 12:26
composer.json:55ReplyNo, I think auto updates for patch level releases is ok, but minor upgrades should be done manually. imho ~5.3.0 is fine here. -
Mathias Brodala commented on patch set 1 CR +1 05/30/16, 12:32
As discussed internally even minor bumps in phpunit can bring e.g. deprecations which should be handled on a case by case basis. -
Frank Nägler voted on patch set 1 CR +1 05/30/16, 12:43
-
Frank Nägler voted on patch set 1 CR +2 V +2 05/30/16, 12:56
-
Gerrit merged patch set 1 05/30/16, 12:56