Review main Merged

48400[TASK] Upgrade to phpunit 5.3

Christian Kuhn CR +2 V +2 Normal +58 −11 updated 05/30/16, 12:56

Commit message

No notable fancy new features as far as I can see,
just a new minor.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Wouter Wolters +1
    • Mathias Brodala +1
  • Verified V +2
    • Frank Nägler +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 9

  1. Christian Kuhn uploaded patch set 1 05/30/16, 10:07

  2. Christian Kuhn commented on patch set 1 05/30/16, 10:09

  3. Wouter Wolters voted on patch set 1 CR +1 V +1 05/30/16, 10:25

  4. Mathias Brodala commented on patch set 1 CR -1 05/30/16, 10:38

    composer.json:55

    How about ^5.3.0 instead to simplify future updates?
  5. Christian Kuhn commented on patch set 1 05/30/16, 12:26

    composer.json:55 Reply

    No, I think auto updates for patch level releases is ok, but minor upgrades should be done manually. imho ~5.3.0 is fine here.
  6. Mathias Brodala commented on patch set 1 CR +1 05/30/16, 12:32

    As discussed internally even minor bumps in phpunit can bring e.g. deprecations which should be handled on a case by case basis.
  7. Frank Nägler voted on patch set 1 CR +1 05/30/16, 12:43

  8. Frank Nägler voted on patch set 1 CR +2 V +2 05/30/16, 12:56

  9. Gerrit merged patch set 1 05/30/16, 12:56