Review main Merged

48404[BUGFIX] Only show CSH icon when EXT:context_help is loaded

Benni Mack CR +2 V +2 Easy +3 −1 updated 06/06/16, 19:25

Commit message

When having EXT:context_help uninstalled an empty button is shown in
Web => Info => PageTSconfig, because the text could not be fetched.

Solution: Only show the button if there is a text inside.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Gianluigi Martino +1
  • Verified V +2
    • Wouter Wolters +2
    • Gianluigi Martino +1

Issues 1

Files 1

Review log 7

  1. Benni Mack uploaded patch set 1 05/30/16, 12:39

  2. Wouter Wolters voted on patch set 1 CR +1 05/30/16, 12:42

  3. Gianluigi Martino voted on patch set 1 CR +1 V +1 05/30/16, 14:02

  4. Wouter Wolters voted on patch set 1 CR +2 V +2 05/30/16, 16:40

  5. Gerrit merged patch set 1 05/30/16, 16:40

  6. Stephan Großberndt commented on patch set 2 06/06/16, 19:19

    backport is missing
  7. Wouter Wolters commented on patch set 2 06/06/16, 19:25

    This was only needed in 8. The change that introduced this was https://review.typo3.org/46986