Review main Merged

48407[TASK] Optimize template handling for FSC: Bullets

Frank Nägler CR +2 V +2 Normal +38 −35 updated 06/03/16, 14:03

Commit message

Split the bullets template from FSC into partials.

Review

  • Code review CR +2
    • Jan Helke +2
    • Wouter Wolters +1
    • Gianluigi Martino +1
    • Andreas Kienast +1
  • Verified V +2
    • Jan Helke +2
    • Marco Bresch +1
    • Riccardo De Contardi +1

Issues 1

Files 4

Review log 11

  1. Frank Nägler uploaded patch set 1 05/30/16, 16:00

  2. Frank Nägler updated the commit message in patch set 2 05/30/16, 16:01

  3. Frank Nägler updated the commit message in patch set 3 05/30/16, 16:01

  4. Riccardo De Contardi commented on patch set 3 V +1 05/30/16, 16:40

    as far as I can see the functionality is mantained
  5. Gianluigi Martino voted on patch set 3 CR +1 05/31/16, 05:31

  6. Wouter Wolters voted on patch set 3 CR +1 05/31/16, 17:19

  7. Andreas Kienast voted on patch set 3 CR +1 06/01/16, 13:04

  8. Marco Bresch commented on patch set 3 V +1 06/03/16, 09:36

    The generated HTML is the same before and after the patch
  9. Jan Helke voted on patch set 3 CR +1 06/03/16, 13:52

  10. Jan Helke voted on patch set 3 CR +2 V +2 06/03/16, 14:03

  11. Gerrit merged patch set 3 06/03/16, 14:03