Review main Merged

48410[FOLLOWUP][TASK] Automatically select the custom preset when values are changed

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 06/03/16, 09:45

Commit message

When input field is changed the checkbox is checked directly, not
after it loses the focus.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Frank Nägler +1
    • Nicole Hummel +1
  • Verified V +2
    • Wouter Wolters +2
    • Nicole Hummel +1

Issues 1

Files 1

Review log 9

  1. Wouter Wolters uploaded patch set 1 05/30/16, 20:16

  2. Nicole Hummel voted on patch set 1 CR +2 V +2 05/30/16, 20:54

  3. Nicole Hummel commented on patch set 1 05/30/16, 20:56

    I would tend to use on('input propertychange') in the 7.6 backport
  4. Markus Klein updated the commit message in patch set 2 05/31/16, 06:15

  5. Markus Klein commented on patch set 2 CR +1 05/31/16, 06:16

    I'm fine with that
  6. Frank Nägler voted on patch set 2 CR +1 06/03/16, 09:27

  7. Nicole Hummel voted on patch set 2 CR +1 V +1 06/03/16, 09:43

  8. Wouter Wolters voted on patch set 2 CR +2 V +2 06/03/16, 09:45

  9. Gerrit merged patch set 2 06/03/16, 09:45