Review main Abandoned

48434[BUGFIX] Use the correct protocol for URLs across domains

David Frerich CR 0 V 0 Easy +1 −1 updated 11/24/17, 21:07

Commit message

This patch resolves the problem with absoluteUrlScheme for urls for
different local domains.

The absolute url to another local domain
(TypoScript setting: config.typolinkEnableLinksAcrossDomains = 1) should
use the same url scheme as the request, specificaly https,
else generated Urls produce mixed content warnings for not
correctly using https:// as the absolute scheme.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 45

  1. David Frerich uploaded patch set 1 06/02/16, 09:11

  2. Wouter Wolters updated the commit message in patch set 2 06/02/16, 09:34

  3. Anja Leichsenring commented on patch set 2 CR -1 06/02/16, 17:49

    the change looks good on first glance, thanks for it. But two issues: 1. there is no forge issue linked. Please link it by including a Resolves: #xxx to the commit message. If no issue yet exists, create one with problem description and reproduce steps. 2. the proposed backport to 6.2 should not take place. 6.2 is in priority mode, only really important bugfixes are allowed in.
  4. TYPO3com voted on patch set 2 V +1 12/04/16, 11:04 Completed build in 20m 02s on Sun, 4 Dec, 12:04 PM Test Summary: 54322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5466

  5. Benni Mack abandoned the change 11/24/17, 21:07

    No ticket, no activity, plus this change has side effects, because then ALL typolinks would have absolute URLs, which is not wanted at all