48442[TASK] Apply CGL compatibility (PSR-1 and PSR-2)
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Wouter Wolters +1
-
Verified V +2
- Helmut Hummel +2
- Wouter Wolters +1
Issues 1
Files 58
- typo3/sysext/backend/Classes/Command/ReferenceIndexUpdateCommand.php+0 −1
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+3 −4
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/InputColorPickerElement.php+0 −3
- typo3/sysext/backend/Classes/View/Wizard/Element/BackendLayoutWizardElement.php+0 −1
- typo3/sysext/backend/Tests/Unit/Controller/FormInlineAjaxControllerTest.php+0 −2
- typo3/sysext/belog/Classes/ViewHelpers/ErrorIconViewHelper.php+0 −1
- typo3/sysext/beuser/Classes/Domain/Repository/BackendUserRepository.php+1 −1
- typo3/sysext/core/Classes/Cache/Frontend/VariableFrontend.php+0 −1
- typo3/sysext/core/Classes/Package/PackageManager.php+2 −1
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+2 −1
- typo3/sysext/core/Classes/Tests/FunctionalTestCase.php+0 −1
- typo3/sysext/core/Classes/TimeTracker/TimeTracker.php+0 −1
- typo3/sysext/core/Classes/Utility/DebugUtility.php+2 −2
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+1 −2
- typo3/sysext/core/Configuration/DefaultConfiguration.php4+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/Extensionmanager/InstalledExtensionsCest.php+2 −3
- typo3/sysext/core/Tests/Acceptance/Backend/Formhandler/CategoryTreeCest.php+2 −5
- typo3/sysext/core/Tests/Acceptance/Backend/General/ModuleMenuCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/Login/BackendLoginCest.php+1 −1
Show 38 more files
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/SearchCest.php+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/FlexformIrre/ActionTestCase.php+0 −1
- typo3/sysext/core/Tests/Unit/Cache/Backend/FileBackendTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Cache/Backend/RedisBackendTest.php+0 −2
- typo3/sysext/core/Tests/Unit/Cache/Fixtures/BackendConfigurationOptionFixture.php+0 −1
- typo3/sysext/core/Tests/Unit/Cache/CacheFactoryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Core/ClassLoadingInformationGeneratorTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/FontawesomeIconProviderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/StringUtilityTest.php+1 −2
- typo3/sysext/core/Tests/AcceptanceCoreEnvironment.php+0 −1
- typo3/sysext/extbase/Classes/Mvc/Web/ReferringRequest.php+0 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapperTest.php+0 −3
- typo3/sysext/extbase/Tests/Unit/Service/ExtensionServiceTest.php+1 −2
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Form/TypoScriptConstantsViewHelper.php+0 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php+0 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ValidationResultsViewHelper.php+0 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/TypolinkViewHelper.php+0 −1
- typo3/sysext/fluid_styled_content/Classes/ViewHelpers/Link/ClickEnlargeViewHelper.php+0 −1
- typo3/sysext/fluid_styled_content/Classes/ViewHelpers/Menu/KeywordsViewHelper.php+0 −1
- typo3/sysext/fluid_styled_content/Classes/ViewHelpers/Menu/SectionViewHelper.php+0 −1
- typo3/sysext/form/Classes/View/Wizard/Element/FormWizardElement.php+0 −1
- typo3/sysext/form/Tests/Unit/Validator/InArrayValidatorTest.php+0 −1
- typo3/sysext/frontend/Classes/Controller/TranslationStatusController.php+5 −6
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Page/PageRepositoryTest.php+0 −1
- typo3/sysext/install/Classes/Controller/BackendModuleController.php+0 −1
- typo3/sysext/install/Classes/Updates/ExtensionManagerTables.php+0 −1
- typo3/sysext/install/Tests/Unit/FolderStructure/DirectoryNodeTest.php+1 −0
- typo3/sysext/install/Tests/Unit/FolderStructure/FileNodeTest.php+1 −0
- typo3/sysext/install/Tests/Unit/FolderStructure/LinkNodeTest.php+1 −0
- typo3/sysext/install/Tests/Unit/Service/SilentConfigurationUpgradeServiceTest.php+1 −1
- typo3/sysext/install/Tests/Unit/Status/StatusUtilityTest.php+1 −1
- typo3/sysext/opendocs/Classes/Backend/ToolbarItems/OpendocsToolbarItem.php+0 −1
- typo3/sysext/scheduler/Classes/Task/AbstractTask.php+0 −1
- typo3/sysext/scheduler/Tests/Unit/CronCommand/NormalizeCommandTest.php+4 −4
- typo3/sysext/setup/Tests/Unit/SetupModuleControllerTest.php+0 −1
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+0 −1
Review log 13
-
Helmut Hummel uploaded patch set 1 06/03/16, 14:29
-
Anja Leichsenring voted on patch set 1 CR +1 V +1 06/03/16, 14:33
-
Wouter Wolters commented on patch set 1 CR -1 06/03/16, 14:40
again does not belong to the commit message -
Wouter Wolters updated the commit message in patch set 2 06/03/16, 14:41
-
Wouter Wolters commented on patch set 2 06/03/16, 14:42
DefaultConfiguration.php:1135does this work in the Install Tool? -
Helmut Hummel commented on patch set 2 06/03/16, 14:45
DefaultConfiguration.php:1135Replynope :) -
Wouter Wolters commented on patch set 2 06/03/16, 15:18
DefaultConfiguration.php:1135Replythis is caused by the fixer single_array_no_trailing_comma -
Benni Mack commented on patch set 2 06/06/16, 12:29
DefaultConfiguration.php:1135ReplyOK. I will fix this in the install tool again then, ok? so no blocker here... -
Wouter Wolters uploaded patch set 3 06/10/16, 07:42
-
Wouter Wolters voted on patch set 3 CR +1 V +1 06/10/16, 07:44
-
Helmut Hummel voted on patch set 3 CR +2 V +2 06/10/16, 09:11
-
Gerrit merged patch set 3 06/10/16, 09:12
-
Helmut Hummel commented on patch set 4 06/10/16, 09:12
thanks Wouter for picking that up again!