Review main Merged

48442[TASK] Apply CGL compatibility (PSR-1 and PSR-2)

Helmut Hummel CR +2 V +2 Normal +40 −83 updated 06/10/16, 09:12

Commit message

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Wouter Wolters +1
  • Verified V +2
    • Helmut Hummel +2
    • Wouter Wolters +1

Issues 1

Files 58

Show 38 more files

Review log 13

  1. Helmut Hummel uploaded patch set 1 06/03/16, 14:29

  2. Anja Leichsenring voted on patch set 1 CR +1 V +1 06/03/16, 14:33

  3. Wouter Wolters commented on patch set 1 CR -1 06/03/16, 14:40

    again does not belong to the commit message
  4. Wouter Wolters updated the commit message in patch set 2 06/03/16, 14:41

  5. Wouter Wolters commented on patch set 2 06/03/16, 14:42

    DefaultConfiguration.php:1135

    does this work in the Install Tool?
  6. Helmut Hummel commented on patch set 2 06/03/16, 14:45

    DefaultConfiguration.php:1135 Reply

    nope :)
  7. Wouter Wolters commented on patch set 2 06/03/16, 15:18

    DefaultConfiguration.php:1135 Reply

    this is caused by the fixer single_array_no_trailing_comma
  8. Benni Mack commented on patch set 2 06/06/16, 12:29

    DefaultConfiguration.php:1135 Reply

    OK. I will fix this in the install tool again then, ok? so no blocker here...
  9. Wouter Wolters uploaded patch set 3 06/10/16, 07:42

  10. Wouter Wolters voted on patch set 3 CR +1 V +1 06/10/16, 07:44

  11. Helmut Hummel voted on patch set 3 CR +2 V +2 06/10/16, 09:11

  12. Gerrit merged patch set 3 06/10/16, 09:12

  13. Helmut Hummel commented on patch set 4 06/10/16, 09:12

    thanks Wouter for picking that up again!