48452[BUGFIX] Fix password evaluation for TCA input field
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Frank Nägler +1
-
Verified V +2
- Anja Leichsenring +2
- Frank Nägler +1
Issues 1
Files 1
Review log 8
-
Matthias Toscanelli uploaded patch set 1 06/05/16, 09:39
-
Frank Nägler commented on patch set 1 CR -1 06/05/16, 11:12
thank you for the patch. The password handling is very fragil and need some special checks. I will check your patch at least tomorrow. This is a temporary -1, because I can't test it today. -
Matthias Toscanelli commented on patch set 1 06/05/16, 12:19
This is not really about password handling. TCA use "password" evaluation only to hide the value for editor. Ref: https://docs.typo3.org/typo3cms/TCAReference/Reference/Columns/Input/Index.html#eval -
Frank Nägler uploaded patch set 2 06/06/16, 10:49
-
Frank Nägler commented on patch set 2 CR +1 V +1 06/06/16, 10:51
thank you for your patch. so, I am fine with the patch. I removed a now unused variable. I can't see a problem, but for 7.6 the patch should be tested again and carefully. -
Anja Leichsenring voted on patch set 2 CR +2 V +2 06/06/16, 10:56
-
Gerrit merged patch set 2 06/06/16, 10:57
-
Anja Leichsenring commented on patch set 3 06/06/16, 10:57
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 8705afe6fb9ea453e4d3a9c3ed826087666477d8