Review main Merged

48453[FEATURE] Render closures with DebuggerUtility::var_dump()

Andreas Kienast CR +2 V +2 Normal +118 −25 updated 06/06/16, 16:47

Commit message

DebuggerUtility::var_dump() is now able to render closures. The source
code of a closure is now rendered in the output.

Review

  • Code review CR +2
    • Susi Moog +2
    • Jörg Bösche +1
  • Verified V +2
    • Susi Moog +2
    • Jörg Bösche +1

Issues 1

Files 2

Review log 8

  1. Andreas Kienast uploaded patch set 1 06/05/16, 14:54

  2. Andreas Kienast uploaded patch set 2 06/05/16, 15:11

  3. Markus Klein commented on patch set 2 06/05/16, 15:53

    DebuggerUtility.php:208

    I don't think a closure can be blacklisted

    DebuggerUtility.php:208

    This reads weird with all the negations, better would be: && (!self::isAlreadyRendered($object) || $plainText)
  4. Andreas Kienast uploaded patch set 3 06/05/16, 16:32

  5. Susi Moog voted on patch set 3 CR +1 V +1 06/06/16, 16:40

  6. Jörg Bösche voted on patch set 3 CR +1 V +1 06/06/16, 16:41

  7. Susi Moog voted on patch set 3 CR +2 V +2 06/06/16, 16:47

  8. Gerrit merged patch set 3 06/06/16, 16:47