48461[BUGFIX] Introduce exception for using offset without limit
Commit message
Review
-
Code review CR +2
- Jan Helke +2
- Wouter Wolters +1
- Anja Leichsenring +1
- Jörg Bösche +1
- Andreas Kienast +1
- Susi Moog +1
-
Verified V +2
- Jan Helke +2
- Anja Leichsenring +1
- Jörg Bösche +1
- Susi Moog +1
Issues 1
Files 2
Review log 25
-
Ian SEBBAGH uploaded patch set 1 06/06/16, 15:51
-
Andreas Kienast commented on patch set 1 CR -1 06/06/16, 15:55
IMO a breaking change and can't go into 7.6 -
Ian SEBBAGH commented on patch set 1 06/06/16, 16:28
Without the exception introduced, we got a sql error anyway, so it will not break more than before. -
Andreas Kienast voted on patch set 1 CR 0 06/06/16, 16:36
-
Ian SEBBAGH uploaded patch set 2 06/06/16, 16:51
-
Andreas Kienast voted on patch set 2 CR +1 06/06/16, 16:53
-
Jörg Bösche commented on patch set 2 CR -1 06/06/16, 17:21
Typo3DbBackend.php:366Should be an InvalidArgument exception. The InvalidArgumentException is a subclass of LogicException. Also the statementParts are kind of arguments for the sql statement. -
Susi Moog commented on patch set 2 06/06/16, 17:22
Did we really get an SQL error before or didn't the function just assume offset = limit and work as if a limit was given? Therefor still delivering results? the latter would mean this actually is breaking, even though it worked by "blind luck" before. -
Ian SEBBAGH commented on patch set 2 06/06/16, 17:33
Before introducing the exception we got "LIMIT [offset],": the comma breaking the sql request. -
Ian SEBBAGH uploaded patch set 3 06/06/16, 18:09
-
Wouter Wolters commented on patch set 3 CR -1 06/06/16, 19:01
Use native invalid argument exception insteadTypo3DbBackend.php:367this is the wrong exception. This is located in ext:install. that does not belong here. -
Ian SEBBAGH uploaded patch set 4 06/07/16, 07:39
-
Susi Moog uploaded patch set 5 06/07/16, 08:25
-
Susi Moog commented on patch set 5 CR +1 V +1 06/07/16, 08:26
Just added a unit test. -
Ian SEBBAGH uploaded patch set 6 06/07/16, 09:23
-
Wouter Wolters voted on patch set 6 CR +1 06/07/16, 09:25
-
Ian SEBBAGH commented on patch set 6 06/07/16, 09:26
Added the @throws -
Susi Moog voted on patch set 6 CR +1 V +1 06/07/16, 09:29
-
Andreas Kienast voted on patch set 6 CR +1 06/07/16, 09:56
-
Anja Leichsenring voted on patch set 6 CR +1 V +1 06/07/16, 10:14
-
Jörg Bösche voted on patch set 6 CR +1 V +1 06/07/16, 10:15
-
Jan Helke voted on patch set 6 CR +1 V +1 06/07/16, 10:15
-
Jan Helke voted on patch set 6 CR +2 V +2 06/07/16, 10:15
-
Gerrit merged patch set 6 06/07/16, 10:16
-
Jan Helke commented on patch set 7 06/07/16, 10:16
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 145bb6ce17848affc6e371b5191d7588db731d6c