Review TYPO3_7-6 Merged

48473[WIP][BUGFIX] Introduce exception for using offset without limit

Jan Helke CR +2 V +2 Easy +38 −0 updated 06/07/16, 12:08

Commit message

In Typo3DbBackend::createQueryCommandParametersFromStatementParts,
if an offset is defined, but no limit is, an LogicException is thrown.

SQL does not provide possibility to set offset without limit.
To retrieve all rows from a certain offset up to the end of the
result set, you can use some large number for the limit.
See: http://dev.mysql.com/doc/refman/5.7/en/select.html

Review

  • Code review CR +2
    • Jan Helke +2
    • Anja Leichsenring +1
  • Verified V +2
    • Jan Helke +2
    • Anja Leichsenring +1

Issues 1

Files 3

Review log 7

  1. Jan Helke commented on patch set 1 06/07/16, 10:16

    Cherry Picked from branch master.
  2. Anja Leichsenring commented on patch set 1 V -1 06/07/16, 10:25

    test fails, Jan working on it
  3. Jan Helke uploaded patch set 2 06/07/16, 10:47

  4. Jan Helke uploaded patch set 3 06/07/16, 11:40

  5. Jan Helke voted on patch set 3 CR +2 V +2 06/07/16, 12:07

  6. Anja Leichsenring voted on patch set 3 CR +1 V +1 06/07/16, 12:07

  7. Gerrit merged patch set 3 06/07/16, 12:08