48474[BUGFIX] Install Tool: target="_blank" on externals links
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Wouter Wolters +1
-
Verified V +2
- Frank Nägler +2
- Wouter Wolters +1
- Riccardo De Contardi +1
Issues 1
Files 1
Review log 16
-
Ian SEBBAGH uploaded patch set 1 06/07/16, 10:16
-
Riccardo De Contardi commented on patch set 1 V +1 06/07/16, 10:22
verified with latest master; verified with both Install Tool loaded inside the CMS and outside it. -
Jörg Bösche uploaded patch set 2 06/07/16, 10:35
-
Jörg Bösche voted on patch set 2 CR +1 06/07/16, 10:37
-
Riccardo De Contardi commented on patch set 2 06/07/16, 10:46
my suggestions for the link titles: "click [for details]" link: title: "detailed information about license" "https://typo3.org/" link: title: "TYPO3 website - the enterprise Open Source CMS" "Donate" link: title: "how to donate" TYPO3.org link: title: "TYPO3 website - the enterprise Open Source CMS" -
Jörg Bösche uploaded patch set 3 06/07/16, 10:58
-
Riccardo De Contardi voted on patch set 3 V +1 06/07/16, 11:02
-
Gordon Brüggemann voted on patch set 3 CR +1 06/07/16, 11:46
-
Wouter Wolters voted on patch set 3 CR +1 V +1 06/07/16, 12:06
-
Stephan Großberndt commented on patch set 3 06/07/16, 12:13
don't want to kill your votes but in general we have a wrap at 72 chars in the commit message -
Stephan Großberndt commented on patch set 4 06/07/16, 12:23
Published edit on patch set 3. -
Wouter Wolters voted on patch set 4 CR +1 V +1 06/07/16, 12:24
-
Riccardo De Contardi voted on patch set 4 V +1 06/07/16, 12:26
-
Frank Nägler voted on patch set 4 CR +2 V +2 06/07/16, 12:28
-
Gerrit merged patch set 4 06/07/16, 12:30
-
Frank Nägler commented on patch set 5 06/07/16, 12:30
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 9fabbdceaa819ae7a8aa79faa27d8ef772e201b1