Review main Merged

48475[FOLLOWUP][BUGFIX] Introduce exception for using offset without limit

Ian SEBBAGH CR +2 V +2 Easy +2 −0 updated 06/07/16, 11:30

Commit message

In Typo3DbBackend::createQueryCommandParametersFromStatementParts,
if an offset is defined, but no limit is, an LogicException is thrown.

SQL does not provide possibility to set offset without limit.
To retrieve all rows from a certain offset up to the end of the
result set, you can use some large number for the limit.
See: http://dev.mysql.com/doc/refman/5.7/en/select.html

Fix failing fonctionnal tests.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • Frank Nägler +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Frank Nägler +1
    • Susi Moog +1

Issues 1

Files 1

Review log 9

  1. Ian SEBBAGH uploaded patch set 1 06/07/16, 10:52

  2. Anja Leichsenring voted on patch set 1 CR +1 V +1 06/07/16, 11:01

  3. Susi Moog voted on patch set 1 CR +1 06/07/16, 11:06

  4. Wouter Wolters voted on patch set 1 CR +1 06/07/16, 11:07

  5. Frank Nägler voted on patch set 1 CR +1 06/07/16, 11:17

  6. Susi Moog voted on patch set 1 V +1 06/07/16, 11:25

  7. Frank Nägler voted on patch set 1 V +1 06/07/16, 11:30

  8. Christian Kuhn voted on patch set 1 CR +2 V +2 06/07/16, 11:30

  9. Gerrit merged patch set 1 06/07/16, 11:30