Review main Merged

48485[BUGFIX] Scheduler to show checkbox if "bool" typehint used in Controller

mostwanted CR +2 V +2 Easy +4 −2 updated 06/08/16, 13:24

Commit message

Until now if you wanted to use a checkbox you had to use "boolean" in that
typehint. If you used "bool" EXT:scheduler output a common input field. As
it seems to be encouraged by the TYPO3 core team to use "bool" PHPDoc
blocks, this commit makes sure that EXT:scheduler will also output a
checkobx if you use "bool" typehints.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Mathias Brodala +1
  • Verified V +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Mathias Brodala +1

Issues 1

Files 1

Review log 18

  1. mostwanted uploaded patch set 1 06/07/16, 15:19

  2. Mathias Brodala commented on patch set 1 CR -1 06/07/16, 15:22

    Please use TypeHandlingUtility::normalizeType() instead which covers this difference already. Yes, Extbase should be updated to cope with the shorter types but this is another topic.
  3. mostwanted uploaded patch set 2 06/07/16, 15:34

  4. Mathias Brodala voted on patch set 2 CR +1 06/07/16, 15:34

  5. Mathias Brodala voted on patch set 2 V +1 06/07/16, 15:42

  6. Stephan Großberndt commented on patch set 2 CR -1 06/07/16, 16:38

    the commit message references the issue and should not contain the complete issue including php code but a short concise message what is changed and why: https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/GitSetup/CommitMessageFormat.html#commit-message-format
  7. mostwanted updated the commit message in patch set 3 06/07/16, 17:29

  8. mostwanted updated the commit message in patch set 4 06/07/16, 17:32

  9. mostwanted updated the commit message in patch set 5 06/07/16, 17:34

  10. Wouter Wolters voted on patch set 5 CR +1 V +1 06/07/16, 19:33

  11. Anja Leichsenring commented on patch set 5 V +1 06/08/16, 12:42

    fine with me, but not for 6.2. This is for sure no priority change.
  12. Mathias Brodala updated the commit message in patch set 6 06/08/16, 12:43

  13. Mathias Brodala commented on patch set 6 06/08/16, 12:43

    > fine with me, but not for 6.2. This is for sure no priority change. Agreed and fixed.
  14. Mathias Brodala voted on patch set 6 CR +1 V +1 06/08/16, 12:43

  15. Wouter Wolters voted on patch set 6 CR +1 V +1 06/08/16, 12:47

  16. Anja Leichsenring voted on patch set 6 CR +2 V +2 06/08/16, 13:23

  17. Gerrit merged patch set 6 06/08/16, 13:23

  18. Anja Leichsenring commented on patch set 7 06/08/16, 13:24

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 1a626980d79e021a2037168a2809953ebce07b9e