48488[TASK] replaced @expectedException in ext:backend
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Frank Nägler +1
- Susi Moog +1
-
Verified V +2
- Christian Kuhn +2
- Frank Nägler +1
- Susi Moog +1
Issues 1
Files 7
- typo3/sysext/backend/Tests/Unit/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php1+3 −1
- typo3/sysext/backend/Tests/Unit/Controller/LoginControllerTest.php+16 −16
- typo3/sysext/backend/Tests/Unit/Form/NodeFactoryTest.php+30 −30
- typo3/sysext/backend/Tests/Unit/Template/Components/Button/SplitButtonTest.php+6 −6
- typo3/sysext/backend/Tests/Unit/View/BackendLayout/BackendLayoutCollectionTest.php+6 −3
- typo3/sysext/backend/Tests/Unit/View/BackendLayout/BackendLayoutTest.php+2 −1
- typo3/sysext/backend/Tests/Unit/View/BackendLayout/DataProviderCollectionTest.php+4 −2
Review log 15
-
Ian SEBBAGH uploaded patch set 1 06/07/16, 16:33
-
Ian SEBBAGH commented on patch set 1 06/07/16, 16:34
Just replace occurences when @expectedExceptionCode was present. Still work to do. -
Ian SEBBAGH updated the commit message in patch set 2 06/07/16, 16:47
-
Jan Helke voted on patch set 2 CR +1 06/08/16, 14:55
-
Jan Helke commented on patch set 2 CR 0 06/08/16, 14:59
As this is still WIP I withdraw my review. -
Ian SEBBAGH uploaded patch set 3 06/08/16, 19:50
-
Ian SEBBAGH voted on patch set 3 CR +1 06/08/16, 19:50
-
Christian Kuhn voted on patch set 3 CR +1 V +1 06/08/16, 19:59
-
Susi Moog commented on patch set 3 CR -1 06/08/16, 20:01
will fix it.ConditionMatcherTest.php:17unnecessary use statement. -
Susi Moog uploaded patch set 4 06/08/16, 20:04
-
Susi Moog voted on patch set 4 CR +1 V +1 06/08/16, 20:04
-
Frank Nägler voted on patch set 4 CR +1 V +1 06/08/16, 20:04
-
Christian Kuhn voted on patch set 4 CR +1 V +1 06/08/16, 20:04
-
Christian Kuhn voted on patch set 4 CR +2 V +2 06/08/16, 20:06
-
Gerrit merged patch set 4 06/08/16, 20:06