Review main Merged

48488[TASK] replaced @expectedException in ext:backend

Ian SEBBAGH CR +2 V +2 Normal +67 −59 updated 06/08/16, 20:06

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • Susi Moog +1

Issues 1

Files 7

Review log 15

  1. Ian SEBBAGH uploaded patch set 1 06/07/16, 16:33

  2. Ian SEBBAGH commented on patch set 1 06/07/16, 16:34

    Just replace occurences when @expectedExceptionCode was present. Still work to do.
  3. Ian SEBBAGH updated the commit message in patch set 2 06/07/16, 16:47

  4. Jan Helke voted on patch set 2 CR +1 06/08/16, 14:55

  5. Jan Helke commented on patch set 2 CR 0 06/08/16, 14:59

    As this is still WIP I withdraw my review.
  6. Ian SEBBAGH uploaded patch set 3 06/08/16, 19:50

  7. Ian SEBBAGH voted on patch set 3 CR +1 06/08/16, 19:50

  8. Christian Kuhn voted on patch set 3 CR +1 V +1 06/08/16, 19:59

  9. Susi Moog commented on patch set 3 CR -1 06/08/16, 20:01

    will fix it.

    ConditionMatcherTest.php:17

    unnecessary use statement.
  10. Susi Moog uploaded patch set 4 06/08/16, 20:04

  11. Susi Moog voted on patch set 4 CR +1 V +1 06/08/16, 20:04

  12. Frank Nägler voted on patch set 4 CR +1 V +1 06/08/16, 20:04

  13. Christian Kuhn voted on patch set 4 CR +1 V +1 06/08/16, 20:04

  14. Christian Kuhn voted on patch set 4 CR +2 V +2 06/08/16, 20:06

  15. Gerrit merged patch set 4 06/08/16, 20:06