Review main Merged

48502[BUGFIX] Improve domObjectId splitting for inline in flexform

Anja Leichsenring CR +2 V +2 Normal +154 −39 updated 06/09/16, 08:54

Commit message

We use a regex to retrieve relevant informations for the handling
of flexform datastructures and inline records. It failed for some
use cases like deeply nested structures.
A rework of the regex and some additional unit tests stabilize
this fragile area.

Review

  • Code review CR +2
    • Susi Moog +2
    • Wouter Wolters +1
    • Jan Rowold +1
  • Verified V +2
    • Susi Moog +2
    • Jan Rowold +1

Issues 1

Files 2

Review log 15

  1. Anja Leichsenring uploaded patch set 1 06/08/16, 11:59

  2. Wouter Wolters commented on patch set 1 06/08/16, 12:12

    rest looks good codewise

    FormInlineAjaxController.php:944

    type missing
  3. Anja Leichsenring uploaded patch set 2 06/08/16, 12:19

  4. Susi Moog voted on patch set 2 CR +1 V +1 06/08/16, 12:27

  5. Wouter Wolters voted on patch set 2 CR +1 06/08/16, 12:38

  6. Jan Helke voted on patch set 2 CR +1 06/08/16, 13:08

  7. Christian Kuhn commented on patch set 2 06/08/16, 18:57

    thx! didn't review yet, but i've send the issue to thomas (one of the first reporters) to re-check if the patch solves the problem.
  8. Anja Leichsenring uploaded patch set 3 06/08/16, 19:51

  9. Anja Leichsenring uploaded patch set 4 06/08/16, 20:00

  10. Susi Moog voted on patch set 4 CR +1 V +1 06/08/16, 20:08

  11. Wouter Wolters voted on patch set 4 CR +1 06/09/16, 07:26

  12. Susi Moog commented on patch set 4 06/09/16, 08:46

  13. Jan Rowold voted on patch set 4 CR +1 V +1 06/09/16, 08:53

  14. Susi Moog voted on patch set 4 CR +2 V +2 06/09/16, 08:54

  15. Gerrit merged patch set 4 06/09/16, 08:54