48503[WIP][TASK] Deprecate usage of $_EXTKEY
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 15
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+14 −14
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+1 −1
- typo3/sysext/core/Classes/Package/PackageManager.php+4 −3
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php2+25 −10
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/ext_localconf.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+1 −0
- typo3/sysext/core/ext_tables.php2+1 −1
- typo3/sysext/documentation/Classes/Utility/MiscUtility.php2+6 −5
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_localconf.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_tables.php+6 −6
- typo3/sysext/extensionmanager/Classes/Utility/EmConfUtility.php2+1 −0
- typo3/sysext/frontend/Classes/Utility/EidUtility.php+1 −0
- typo3/sysext/install/Classes/Controller/Action/Ajax/ExtensionCompatibilityTester.php+4 −2
- typo3/sysext/scheduler/Documentation/DevelopersGuide/CreatingTasks/Index.rst+3 −3
- typo3/sysext/t3editor/Resources/Private/tsref.xml+2 −2
Review log 1418
-
Frank Nägler uploaded patch set 1 06/08/16, 12:01
-
Helmut Hummel commented on patch set 1 CR -2 06/08/16, 13:09
Sorry, but we can't do this. The given patch here I consider counter productive for what we need or where we want to go. There is code relying on the $_EXTKEY to be present. Currently TYPO3, TER and our composer/typo3-cms-installer relies on a specific syntax of these files. Changing the syntax will require code changes in all of these areas at the same time. To proceed in ext_emconf.php changes the following needs to be done beforehand: * Define a strict standard for these files * create a generator/ linter/ validator for ext_emconf.php files * create independent code (composer package) to parse these files * use this package in every place we read configuration from ext_emconf.php If we skip any of these steps, we will very likely break arbitrary places in our product and infrastructure. Since the requirements to make change in this area are quite extensive it may be reasonable to deprecate ext_emconf.php altogether and using the composer.json for extension meta data extraction. For this to succeed, we need to find a solution for the following topics: * How do we want to deal with extension versions. Where store this info, when read it. * How do we deal with dependency information for the current EM, since the EM cannot read composer version constraints and should ignore constraints to composer packages that are not extensions * Where to we want to put additional meta information, that has no direct counterpart in composer.json like "description" I'm glad to see such actions in this area. I'm happy to help out or discuss concepts -
Helmut Hummel commented on patch set 1 06/08/16, 13:48
One alternative step would be to create a ext_emconf.php *Parser* that can does not require that PHP file to be included but can reliably parse the ext_emconf.php That code in place, we can put that into a composer package and use it in every part of our infrastructure -
Helmut Hummel commented on patch set 1 CR -1 06/08/16, 13:52
Oh, and removing $_EXTKEY in any other place except ext_emconf.php is of course fine. the -2 was for ext_emconf.php changes only. So if the patch here is re-worked to only tackle ext_localconf.php and ext_tables.php I would be very fine -
Wouter Wolters commented on patch set 1 06/08/16, 14:40
please check Benni his pending reviews as well. He has something in progress in this area. -
Frank Nägler uploaded patch set 2 08/30/16, 11:30
-
Frank Nägler uploaded patch set 3 08/30/16, 11:33
-
TYPO3com voted on patch set 2 V +1 08/30/16, 11:33 Completed build in 02m 37s on Tue, 30 Aug, 01:33 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2433
-
TYPO3com voted on patch set 3 V +1 08/30/16, 11:36 Completed build in 02m 46s on Tue, 30 Aug, 01:36 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2434
-
Frank Nägler uploaded patch set 4 08/30/16, 11:36
-
TYPO3com voted on patch set 4 V +1 08/30/16, 11:39 Completed build in 02m 53s on Tue, 30 Aug, 01:39 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2436
-
Helmut Hummel commented on patch set 4 08/30/16, 13:38
ExtensionManagementUtility.php:1103we can log a deprecation message if $extensionKey is nullExtensionManagementUtility.php:1313same hereMiscUtility.php:32you cannot remove that here…MiscUtility.php:35…because it is required when including this fileEmConfUtility.php:30same here! you cannot change that here!EmConfUtility.php:70don't change that. ext_emconf.php needs to stay the same -
Stefan Neufeind commented on patch set 4 CR -1 08/31/16, 10:27
will update it to resolve merge-conflict and take care of the comments -
Stefan Neufeind uploaded patch set 5 08/31/16, 11:36
-
TYPO3com voted on patch set 5 V -1 08/31/16, 11:39 Completed build in 02m 30s on Wed, 31 Aug, 01:39 PM Test Summary: 18650 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2522
-
Benni Mack commented on patch set 5 08/31/16, 12:18
ext_tables.php:82in my code the method does not have a third parameter. -
Stefan Neufeind commented on patch set 5 08/31/16, 13:35
ext_tables.php:82ReplyBenni confirmed all is fine here - parameter is added by this patch. We'll take a closer look again later. -
Frank Nägler abandoned the change 08/18/17, 08:23