Review main Merged

48506[TASK] Replace @expectedException with code wise test in ext:core

Jörg Bösche CR +2 V +2 Expert +734 −344 updated 06/08/16, 14:58

Commit message

The patch replaces the @expectedException annotation with
the phpUnit code wise methods. On every expectedException test
we are especially take care to take the exception code in account.
Also refactoring array syntax and line formats.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Susi Moog +1
  • Verified V +2
    • Anja Leichsenring +2
    • Susi Moog +1

Issues 1

Files 58

Show 38 more files

Review log 13

  1. Jörg Bösche uploaded patch set 1 06/08/16, 12:41

  2. Jörg Bösche uploaded patch set 2 06/08/16, 13:19

  3. Jörg Bösche commented on patch set 1 06/08/16, 13:22

    The files for Xcache and redis got todo comments for exception code, because of missing redis-server on my dev-env and no available xcache module under php 7.x. - sysext/core/Tests/Unit/Cache/Backend/XcacheBackendTest.php - sysext/core/Tests/Unit/Cache/Backend/RedisBackendTest.php
  4. Jörg Bösche uploaded patch set 3 06/08/16, 13:35

  5. Jörg Bösche uploaded patch set 4 06/08/16, 13:49

  6. Anja Leichsenring voted on patch set 4 CR +1 V +1 06/08/16, 14:06

  7. Susi Moog commented on patch set 4 V -1 06/08/16, 14:30

    on it
  8. Susi Moog uploaded patch set 5 06/08/16, 14:39

  9. Susi Moog commented on patch set 5 CR -1 06/08/16, 14:42

    i'm stupid. still on it.
  10. Susi Moog uploaded patch set 6 06/08/16, 14:52

  11. Susi Moog voted on patch set 6 CR +1 V +1 06/08/16, 14:53

  12. Anja Leichsenring voted on patch set 6 CR +2 V +2 06/08/16, 14:58

  13. Gerrit merged patch set 6 06/08/16, 14:58