48506[TASK] Replace @expectedException with code wise test in ext:core
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Susi Moog +1
-
Verified V +2
- Anja Leichsenring +2
- Susi Moog +1
Issues 1
Files 58
- typo3/sysext/core/Tests/Functional/Database/DatabaseConnectionTest.php+7 −3
- typo3/sysext/core/Tests/Unit/Cache/Backend/ApcBackendTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Cache/Backend/FileBackendTest.php+23 −8
- typo3/sysext/core/Tests/Unit/Cache/Backend/MemcachedBackendTest.php+6 −2
- typo3/sysext/core/Tests/Unit/Cache/Backend/PdoBackendTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Cache/Backend/RedisBackendTest.php+45 −14
- typo3/sysext/core/Tests/Unit/Cache/Backend/TransientMemoryBackendTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Cache/Backend/Typo3DatabaseBackendTest.php+28 −9
- typo3/sysext/core/Tests/Unit/Cache/Backend/WincacheBackendTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Cache/Backend/XcacheBackendTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Cache/Frontend/AbstractFrontendTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Cache/Frontend/PhpFrontendTest.php+7 −2
- typo3/sysext/core/Tests/Unit/Cache/Frontend/StringFrontendTest.php+10 −3
- typo3/sysext/core/Tests/Unit/Cache/Frontend/VariableFrontendTest.php+6 −2
- typo3/sysext/core/Tests/Unit/Cache/CacheManagerTest.php+13 −4
- typo3/sysext/core/Tests/Unit/Category/Collection/CategoryCollectionTest.php+5 −2
- typo3/sysext/core/Tests/Unit/Category/CategoryRegistryTest.php+12 −8
- typo3/sysext/core/Tests/Unit/Collection/RecordCollectionRepositoryTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Configuration/ConfigurationManagerTest.php+7 −3
- typo3/sysext/core/Tests/Unit/Core/ApplicationContextTest.php+3 −1
Show 38 more files
- typo3/sysext/core/Tests/Unit/Core/ClassLoadingInformationGeneratorTest.php+7 −4
- typo3/sysext/core/Tests/Unit/Database/Query/BulkInsertTest.php+27 −15
- typo3/sysext/core/Tests/Unit/Database/Query/QueryBuilderTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Database/DatabaseConnectionTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Database/PreparedStatementTest.php+26 −12
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+3 −2
- typo3/sysext/core/Tests/Unit/FormProtection/BackendFormProtectionTest.php+6 −3
- typo3/sysext/core/Tests/Unit/FormProtection/FormProtectionFactoryTest.php+6 −2
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/FontawesomeIconProviderTest.php+11 −8
- typo3/sysext/core/Tests/Unit/Imaging/IconRegistryTest.php+6 −2
- typo3/sysext/core/Tests/Unit/Locking/LockFactoryTest.php+7 −3
- typo3/sysext/core/Tests/Unit/Log/Processor/AbstractProcessorTest.php+7 −2
- typo3/sysext/core/Tests/Unit/Log/Writer/AbstractWriterTest.php+6 −2
- typo3/sysext/core/Tests/Unit/Log/Writer/DatabaseWriterTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Log/LogLevelTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Log/LogRecordTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Mail/MailerTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Package/DependencyResolverTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Package/PackageManagerTest.php+14 −4
- typo3/sysext/core/Tests/Unit/Package/PackageTest.php+8 −2
- typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php+12 −4
- typo3/sysext/core/Tests/Unit/Resource/Collection/FileCollectionRegistryTest.php+12 −8
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+4 −1
- typo3/sysext/core/Tests/Unit/Resource/Index/ExtractorRegistryTest.php+6 −4
- typo3/sysext/core/Tests/Unit/Resource/Rendering/RendererRegistryTest.php+6 −4
- typo3/sysext/core/Tests/Unit/Resource/TextExtraction/TextExtractorRegistryTest.php+6 −4
- typo3/sysext/core/Tests/Unit/Resource/FileReferenceTest.php+15 −10
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Service/DependencyOrderingServiceTest.php+3 −2
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/TreeDataProviderFactoryTest.php+63 −39
- typo3/sysext/core/Tests/Unit/Type/EnumerationTest.php+23 −7
- typo3/sysext/core/Tests/Unit/TypoScript/TemplateServiceTest.php+5 −2
- typo3/sysext/core/Tests/Unit/Utility/ArrayUtilityTest.php+51 −28
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+50 −23
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+59 −26
- typo3/sysext/core/Tests/Unit/Utility/RootlineUtilityTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Utility/StringUtilityTest.php+47 −38
- typo3/sysext/core/Tests/Unit/RegistryTest.php+18 −6
Review log 13
-
Jörg Bösche uploaded patch set 1 06/08/16, 12:41
-
Jörg Bösche uploaded patch set 2 06/08/16, 13:19
-
Jörg Bösche commented on patch set 1 06/08/16, 13:22
The files for Xcache and redis got todo comments for exception code, because of missing redis-server on my dev-env and no available xcache module under php 7.x. - sysext/core/Tests/Unit/Cache/Backend/XcacheBackendTest.php - sysext/core/Tests/Unit/Cache/Backend/RedisBackendTest.php -
Jörg Bösche uploaded patch set 3 06/08/16, 13:35
-
Jörg Bösche uploaded patch set 4 06/08/16, 13:49
-
Anja Leichsenring voted on patch set 4 CR +1 V +1 06/08/16, 14:06
-
Susi Moog commented on patch set 4 V -1 06/08/16, 14:30
on it -
Susi Moog uploaded patch set 5 06/08/16, 14:39
-
Susi Moog commented on patch set 5 CR -1 06/08/16, 14:42
i'm stupid. still on it. -
Susi Moog uploaded patch set 6 06/08/16, 14:52
-
Susi Moog voted on patch set 6 CR +1 V +1 06/08/16, 14:53
-
Anja Leichsenring voted on patch set 6 CR +2 V +2 06/08/16, 14:58
-
Gerrit merged patch set 6 06/08/16, 14:58