Review main Merged Breaking

48511[!!!][TASK] Cleanup ContextMenu classes

Frank Nägler CR +2 V +2 Hard +306 −437 updated 06/10/16, 13:59

Commit message

As a pre-patch for the cleanups in the page tree, this patch removes unused
classes and simplifies the class structure. All this classes never used
outside the core.
A search in the TER doesn't find any usages.
For this reason, we decided to not deprecate the classes but made a
breaking change.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 8

Review log 15

  1. Frank Nägler uploaded patch set 1 06/08/16, 15:40

  2. Andreas Kienast updated the commit message in patch set 2 06/08/16, 16:46

  3. Georg Ringer commented on patch set 3 06/08/16, 19:28

    Published edit on patch set 2.
  4. Benni Mack commented on patch set 3 06/09/16, 05:54

    wow, where did you dig up this one? Seems like it has never been used in the wild (no ext in TER using that). So the breaking change seems fine. Could you add more info to the commit message (that it's related to the ContextMenu of ExtJS)
  5. Frank Nägler uploaded patch set 4 06/09/16, 08:05

  6. Wouter Wolters commented on patch set 4 06/10/16, 07:00

    will review this today
  7. Wouter Wolters voted on patch set 4 CR +1 V +1 06/10/16, 07:22

  8. Christian Kuhn commented on patch set 4 CR -1 06/10/16, 10:00

    working on it.
  9. Christian Kuhn commented on patch set 4 06/10/16, 10:13

    one error on testing, please see forge for screenshots.
  10. Christian Kuhn commented on patch set 4 06/10/16, 10:14

    both enable and disable entries are shown for me after the patch, see forge.
  11. Frank Nägler uploaded patch set 5 06/10/16, 10:46

  12. Frank Nägler commented on patch set 5 06/10/16, 10:47

    good catch, fixed in patchset 5
  13. Christian Kuhn voted on patch set 5 CR +1 V +1 06/10/16, 11:58

  14. Wouter Wolters voted on patch set 5 CR +2 V +2 06/10/16, 13:59

  15. Gerrit merged patch set 5 06/10/16, 13:59