Review main Merged

48512[FEATURE] Add new ViewHelper for record icons

Frank Nägler CR +2 V +2 Normal +151 −0 updated 06/08/16, 19:09

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Jan Helke +1
    • Christian Kuhn +1
    • Susi Moog +1
  • Verified V +2
    • Wouter Wolters +2
    • Jan Helke +1
    • Christian Kuhn +1
    • Susi Moog +1

Issues 1

Files 3

Review log 16

  1. Frank Nägler uploaded patch set 1 06/08/16, 15:55

  2. Ian SEBBAGH voted on patch set 1 CR +1 V +1 06/08/16, 16:04

  3. Jan Helke voted on patch set 1 CR +1 06/08/16, 16:14

  4. Jan Helke voted on patch set 1 V +1 06/08/16, 16:20

  5. Anja Leichsenring commented on patch set 1 CR -1 06/08/16, 16:20

    unit test in progress
  6. Frank Nägler uploaded patch set 2 06/08/16, 16:36

  7. Jan Helke voted on patch set 2 CR +1 V +1 06/08/16, 17:04

  8. Susi Moog uploaded patch set 3 06/08/16, 17:36

  9. Susi Moog commented on patch set 3 CR +1 V +1 06/08/16, 17:41

    verified by unit tests.
  10. Wouter Wolters commented on patch set 3 CR -1 06/08/16, 17:44

    hold on please here
  11. Frank Nägler uploaded patch set 4 06/08/16, 18:39

  12. Christian Kuhn commented on patch set 4 CR +1 V +1 06/08/16, 18:47

    looks good to me now. wouter, what do you think?
  13. Jan Helke voted on patch set 4 CR +1 V +1 06/08/16, 18:52

  14. Susi Moog voted on patch set 4 CR +1 V +1 06/08/16, 18:56

  15. Wouter Wolters voted on patch set 4 CR +2 V +2 06/08/16, 19:09

  16. Gerrit merged patch set 4 06/08/16, 19:09