48515[TASK] TemplateAnalyzerModule move to Fluid StandaloneView
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Frank Nägler +1
- Jörg Bösche +1
- Susi Moog +1
- Jan Rowold +1
-
Verified V +2
- Christian Kuhn +2
- Frank Nägler +1
- Jörg Bösche +1
- Jan Rowold +1
Issues 2
Files 2
Review log 39
Show 14 earlier messages
-
Ian SEBBAGH uploaded patch set 1 06/08/16, 18:18
-
Ian SEBBAGH commented on patch set 1 CR -1 06/08/16, 18:20
Waiting for #48512 to be merged -
Ian SEBBAGH commented on patch set 1 06/08/16, 18:21
Not #48512 ! But: https://review.typo3.org/#/c/48512/ -
Ian SEBBAGH voted on patch set 1 CR +1 V +1 06/08/16, 19:13
-
Frank Nägler uploaded patch set 2 06/08/16, 20:13
-
Christian Kuhn commented on patch set 1 06/08/16, 20:15
nice! looks good on first reading already. some details like the former global assignments should have dedicated eyes. -
Jörg Bösche commented on patch set 2 CR +1 V +1 06/09/16, 08:26
HTML output is ok. New template is rendered and equal to the old implementation. -
Wouter Wolters commented on patch set 2 06/09/16, 08:29
TemplateAnalyzerModuleFunctionController.php:61I would not put this in a protected property but just place this string in to the only place where it is used.TemplateAnalyzerModuleFunctionController.php:77not sure about this change. I remember this is here for a reason. Can we get Markus Klein involved here? -
Markus Klein commented on patch set 2 CR -1 06/09/16, 08:36
TemplateAnalyzerModuleFunctionController.php:77ReplyThis is done, since global is used to communicate with the parent classes, eg the module controller. I'm -1 to changing this, without a proper refactoring of the whole class structure here. (getting rid of the globals) -
Frank Nägler commented on patch set 2 CR -1 06/09/16, 08:42
on it, will push an updateTemplateAnalyzerModuleFunctionController.php:85\TYPO3\CMS\Core\TypoScript\ExtendedTemplateService::getRootLine use this global variable -
Frank Nägler commented on patch set 2 06/09/16, 08:43
TemplateAnalyzerModuleFunctionController.php:77Replyimho changing $GLOBALS['tmpl'] is ok here, but the change for $GLOBALS['rootline'] is not ok ;) I will push an update soon -
Frank Nägler uploaded patch set 3 06/09/16, 08:44
-
Frank Nägler uploaded patch set 4 06/09/16, 09:39
-
Frank Nägler commented on patch set 4 06/09/16, 09:43
After talking to Markus, we decided to keep the $GLOBALS['tplRow'] and $GLOBALS['rootline'] for now and take care in separate patch of the globals variables. I have created an issue for this special task: https://forge.typo3.org/issues/76545
-
Jan Rowold voted on patch set 4 CR +1 V +1 06/09/16, 11:30
-
Jörg Bösche voted on patch set 4 CR +1 V +1 06/09/16, 11:42
-
Frank Nägler uploaded patch set 5 06/09/16, 12:24
-
Frank Nägler uploaded patch set 6 06/09/16, 12:26
-
Frank Nägler uploaded patch set 7 06/09/16, 12:27
-
Frank Nägler rebased onto patch set 8 06/09/16, 13:42
-
Jan Rowold commented on patch set 8 CR -1 06/09/16, 13:51
unused function getExtendedTemplateService, remove or use this in line 124TemplateAnalyzerModuleFunctionController.php:240unused function getExtendedTemplateService, remove or use this in line 124 -
Frank Nägler commented on patch set 9 06/09/16, 13:58
Published edit on patch set 8. -
Jan Rowold voted on patch set 9 CR +1 V +1 06/09/16, 14:03
-
Jörg Bösche voted on patch set 9 CR +1 V +1 06/09/16, 14:11
-
Christian Kuhn voted on patch set 9 V -1 06/09/16, 14:11
-
Christian Kuhn commented on patch set 9 06/09/16, 14:12
broken: if there are mulitple ts records on one page, the select drop-down is broken. -
Christian Kuhn commented on patch set 9 06/09/16, 14:14
frank will fix. -
Frank Nägler uploaded patch set 10 06/09/16, 14:15
-
Frank Nägler voted on patch set 10 CR +1 V +1 06/09/16, 14:16
-
Jörg Bösche commented on patch set 10 CR +1 V +1 06/09/16, 14:31
The dropdown is beeing rendered and is visible with patch set 10. -
Jan Rowold commented on patch set 10 CR -1 06/09/16, 14:31
TemplateAnalyzerModuleFunction.html:11use spaces instead of tabsTemplateAnalyzerModuleFunction.html:14watch out for indenting -
Christian Kuhn uploaded patch set 11 06/09/16, 14:39
-
Jan Rowold voted on patch set 11 CR +1 V +1 06/09/16, 14:40
-
Susi Moog voted on patch set 11 CR +1 06/09/16, 14:40
-
Jörg Bösche voted on patch set 11 CR +1 V +1 06/09/16, 14:40
-
Frank Nägler voted on patch set 11 CR +1 V +1 06/09/16, 14:41
-
Christian Kuhn voted on patch set 11 CR +2 V +2 06/09/16, 14:41
-
Gerrit merged patch set 11 06/09/16, 14:41
-
Susi Moog voted on patch set 11 V +1 06/09/16, 14:41