Review main Merged

48515[TASK] TemplateAnalyzerModule move to Fluid StandaloneView

Ian SEBBAGH CR +2 V +2 Hard +165 −96 updated 06/09/16, 14:41

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • Jörg Bösche +1
    • Susi Moog +1
    • Jan Rowold +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • Jörg Bösche +1
    • Jan Rowold +1

Issues 2

Files 2

Review log 39

Show 14 earlier messages
  1. Ian SEBBAGH uploaded patch set 1 06/08/16, 18:18

  2. Ian SEBBAGH commented on patch set 1 CR -1 06/08/16, 18:20

    Waiting for #48512 to be merged
  3. Ian SEBBAGH commented on patch set 1 06/08/16, 18:21

  4. Ian SEBBAGH voted on patch set 1 CR +1 V +1 06/08/16, 19:13

  5. Frank Nägler uploaded patch set 2 06/08/16, 20:13

  6. Christian Kuhn commented on patch set 1 06/08/16, 20:15

    nice! looks good on first reading already. some details like the former global assignments should have dedicated eyes.
  7. Jörg Bösche commented on patch set 2 CR +1 V +1 06/09/16, 08:26

    HTML output is ok. New template is rendered and equal to the old implementation.
  8. Wouter Wolters commented on patch set 2 06/09/16, 08:29

    TemplateAnalyzerModuleFunctionController.php:61

    I would not put this in a protected property but just place this string in to the only place where it is used.

    TemplateAnalyzerModuleFunctionController.php:77

    not sure about this change. I remember this is here for a reason. Can we get Markus Klein involved here?
  9. Markus Klein commented on patch set 2 CR -1 06/09/16, 08:36

    TemplateAnalyzerModuleFunctionController.php:77 Reply

    This is done, since global is used to communicate with the parent classes, eg the module controller. I'm -1 to changing this, without a proper refactoring of the whole class structure here. (getting rid of the globals)
  10. Frank Nägler commented on patch set 2 CR -1 06/09/16, 08:42

    on it, will push an update

    TemplateAnalyzerModuleFunctionController.php:85

    \TYPO3\CMS\Core\TypoScript\ExtendedTemplateService::getRootLine use this global variable
  11. Frank Nägler commented on patch set 2 06/09/16, 08:43

    TemplateAnalyzerModuleFunctionController.php:77 Reply

    imho changing $GLOBALS['tmpl'] is ok here, but the change for $GLOBALS['rootline'] is not ok ;) I will push an update soon
  12. Frank Nägler uploaded patch set 3 06/09/16, 08:44

  13. Frank Nägler uploaded patch set 4 06/09/16, 09:39

  14. Frank Nägler commented on patch set 4 06/09/16, 09:43

    After talking to Markus, we decided to keep the $GLOBALS['tplRow'] and $GLOBALS['rootline'] for now and take care in separate patch of the globals variables. I have created an issue for this special task: https://forge.typo3.org/issues/76545
  1. Jan Rowold voted on patch set 4 CR +1 V +1 06/09/16, 11:30

  2. Jörg Bösche voted on patch set 4 CR +1 V +1 06/09/16, 11:42

  3. Frank Nägler uploaded patch set 5 06/09/16, 12:24

  4. Frank Nägler uploaded patch set 6 06/09/16, 12:26

  5. Frank Nägler uploaded patch set 7 06/09/16, 12:27

  6. Frank Nägler rebased onto patch set 8 06/09/16, 13:42

  7. Jan Rowold commented on patch set 8 CR -1 06/09/16, 13:51

    unused function getExtendedTemplateService, remove or use this in line 124

    TemplateAnalyzerModuleFunctionController.php:240

    unused function getExtendedTemplateService, remove or use this in line 124
  8. Frank Nägler commented on patch set 9 06/09/16, 13:58

    Published edit on patch set 8.
  9. Jan Rowold voted on patch set 9 CR +1 V +1 06/09/16, 14:03

  10. Jörg Bösche voted on patch set 9 CR +1 V +1 06/09/16, 14:11

  11. Christian Kuhn voted on patch set 9 V -1 06/09/16, 14:11

  12. Christian Kuhn commented on patch set 9 06/09/16, 14:12

    broken: if there are mulitple ts records on one page, the select drop-down is broken.
  13. Christian Kuhn commented on patch set 9 06/09/16, 14:14

    frank will fix.
  14. Frank Nägler uploaded patch set 10 06/09/16, 14:15

  15. Frank Nägler voted on patch set 10 CR +1 V +1 06/09/16, 14:16

  16. Jörg Bösche commented on patch set 10 CR +1 V +1 06/09/16, 14:31

    The dropdown is beeing rendered and is visible with patch set 10.
  17. Jan Rowold commented on patch set 10 CR -1 06/09/16, 14:31

    TemplateAnalyzerModuleFunction.html:11

    use spaces instead of tabs

    TemplateAnalyzerModuleFunction.html:14

    watch out for indenting
  18. Christian Kuhn uploaded patch set 11 06/09/16, 14:39

  19. Jan Rowold voted on patch set 11 CR +1 V +1 06/09/16, 14:40

  20. Susi Moog voted on patch set 11 CR +1 06/09/16, 14:40

  21. Jörg Bösche voted on patch set 11 CR +1 V +1 06/09/16, 14:40

  22. Frank Nägler voted on patch set 11 CR +1 V +1 06/09/16, 14:41

  23. Christian Kuhn voted on patch set 11 CR +2 V +2 06/09/16, 14:41

  24. Gerrit merged patch set 11 06/09/16, 14:41

  25. Susi Moog voted on patch set 11 V +1 06/09/16, 14:41