Review TYPO3_7-6 Merged

48518[BUGFIX] Improve domObjectId splitting for inline in flexform

Anja Leichsenring CR +2 V +2 Normal +152 −37 updated 06/09/16, 09:43

Commit message

We use a regex to retrieve relevant informations for the handling
of flexform datastructures and inline records. It failed for some
use cases like deeply nested structures.
A rework of the regex and some additional unit tests stabilize
this fragile area.

Review

  • Code review CR +2
    • Susi Moog +2
    • ToM +1
  • Verified V +2
    • Susi Moog +2
    • ToM +1

Issues 1

Files 2

Review log 9

  1. Anja Leichsenring uploaded patch set 1 06/08/16, 19:30

  2. Anja Leichsenring commented on patch set 1 CR -1 06/08/16, 19:30

    wait for master patch to be merged
  3. Anja Leichsenring uploaded patch set 2 06/08/16, 19:53

  4. Anja Leichsenring commented on patch set 2 CR -2 06/08/16, 19:56

    wait for the master patch to get merged
  5. Anja Leichsenring uploaded patch set 3 06/08/16, 19:58

  6. ToM commented on patch set 3 CR +1 V +1 06/08/16, 20:01

    looks good! solve for me!
  7. Anja Leichsenring voted on patch set 3 CR 0 06/09/16, 09:05

  8. Susi Moog voted on patch set 3 CR +2 V +2 06/09/16, 09:43

  9. Gerrit merged patch set 3 06/09/16, 09:43