Review main Merged

48528[FOLLOWUP][BUGFIX] Improve domObjectId splitting for inline in flexform

Anja Leichsenring CR +2 V +2 Easy +2 −2 updated 06/09/16, 12:06

Commit message

Thanks to activated strict typing in FormInlineAjaxController the
third parameter of removeFromArray is not accepted anymore. Declared
the right type it works again.

Review

  • Code review CR +2
    • Jan Helke +2
    • Christian Kuhn +1
    • Morton Jonuschat +1
    • Susi Moog +1
  • Verified V +2
    • Jan Helke +2
    • Morton Jonuschat +1
    • Susi Moog +1

Issues 1

Files 1

Review log 7

  1. Anja Leichsenring uploaded patch set 1 06/09/16, 11:37

  2. Susi Moog voted on patch set 1 CR +1 06/09/16, 11:44

  3. Morton Jonuschat voted on patch set 1 CR +1 V +1 06/09/16, 11:46

  4. Susi Moog voted on patch set 1 V +1 06/09/16, 11:48

  5. Christian Kuhn voted on patch set 1 CR +1 06/09/16, 12:05

  6. Jan Helke voted on patch set 1 CR +2 V +2 06/09/16, 12:06

  7. Gerrit merged patch set 1 06/09/16, 12:06