Review main Merged

48546[BUGFIX] Fix some sql errors running functional tests

Christian Kuhn CR +2 V +2 Easy +2 −0 updated 06/27/16, 13:40

Commit message

When executing the functional tests, the setUp() method
uses the extbase ObjectManager to populate the database schema.
The ObjectManager however relies on ready database schema
in the object reflection. This chicken-egg situation triggers
a lot of sql errors like "table cf_extbase_object does not exist".
For now, the solution is to switch to the NullBackend for this
cache in functional tests LocalConfiguration, since using
the object manager can not be dropped easily.
travis-ci does not show these failing queries due to the
parellelization, this part, together with other failing
queries should be fixed with further patches.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2339

Show 1014 earlier messages
  1. Christian Kuhn uploaded patch set 1 06/10/16, 08:46

  2. Christian Kuhn updated the commit message in patch set 2 06/10/16, 08:49

  3. Wouter Wolters voted on patch set 2 CR +1 06/10/16, 08:52

  4. Christian Kuhn commented on patch set 2 CR -1 06/10/16, 09:00

    -1 from myself for the time being, maybe it is still not that simple, need to dig deeper.
  5. Christian Kuhn uploaded patch set 3 06/22/16, 15:22

  6. Christian Kuhn commented on patch set 3 06/22/16, 15:22

    wip - added a syntax error to test something else ...
  7. TYPO3com voted on patch set 3 V -1 06/22/16, 15:27 Build completed at: https://bamboo.typo3.com/browse/CORE-GTC-113

  8. Christian Kuhn uploaded patch set 4 06/22/16, 15:39

  9. Christian Kuhn uploaded patch set 5 06/22/16, 15:41

  10. TYPO3com voted on patch set 4 V -1 06/22/16, 15:52 Build completed at: https://bamboo.typo3.com/browse/CORE-GTC-114

  11. TYPO3com voted on patch set 5 V +1 06/22/16, 16:02 Build completed at: https://bamboo.typo3.com/browse/CORE-GTC-115

  12. Christian Kuhn uploaded patch set 6 06/22/16, 16:29

  13. Christian Kuhn uploaded patch set 7 06/22/16, 16:33

  14. TYPO3com voted on patch set 6 V -1 06/22/16, 16:34 Build completed at: https://bamboo.typo3.com/browse/CORE-GTC-116

  1. TYPO3com commented on patch set 7 06/22/16, 16:38 Build completed at: https://bamboo.typo3.com/browse/CORE-GTC-117

  2. TYPO3com commented on patch set 7 06/22/16, 16:58 Build completed at: https://bamboo.typo3.com/browse/CORE-GTC-117

  3. TYPO3com voted on patch set 7 V -1 06/22/16, 16:59 Build completed at: https://bamboo.typo3.com/browse/CORE-GTC-118

  4. TYPO3com voted on patch set 7 V +1 06/22/16, 17:06 Build completed at: https://bamboo.typo3.com/browse/CORE-GTC-119

  5. Christian Kuhn uploaded patch set 8 06/22/16, 17:13

  6. Christian Kuhn uploaded patch set 9 06/22/16, 17:15

  7. Christian Kuhn uploaded patch set 10 06/22/16, 17:19

  8. TYPO3com voted on patch set 8 V -1 06/22/16, 17:24 Build completed at: https://bamboo.typo3.com/browse/CORE-GTC-120

  9. TYPO3com voted on patch set 9 V +1 06/22/16, 17:31 Build completed at: https://bamboo.typo3.com/browse/CORE-GTC-121

  10. TYPO3com commented on patch set 10 06/22/16, 17:33 Build completed at: https://bamboo.typo3.com/browse/CORE-GTC-122

  11. Christian Kuhn uploaded patch set 11 06/22/16, 17:41

  12. Christian Kuhn uploaded patch set 12 06/22/16, 21:37

  13. Christian Kuhn uploaded patch set 13 06/22/16, 21:47

  14. TYPO3com voted on patch set 12 V -1 06/22/16, 21:53 Build completed at: https://bamboo.typo3.com/browse/CORE-GTC-131

  15. TYPO3com voted on patch set 13 V -1 06/22/16, 21:59 Build completed at: https://bamboo.typo3.com/browse/CORE-GTC-132

  16. TYPO3com voted on patch set 13 V +1 06/22/16, 22:23 Build completed at: https://bamboo.typo3.com/browse/CORE-GTC-132

  17. Morton Jonuschat updated the commit message in patch set 14 06/24/16, 17:54

  18. TYPO3com voted on patch set 14 V +1 06/24/16, 18:00 Completed build in 05m 49s on Fri, 24 Jun, 08:00 PM Test Summary: 9394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-194

  19. Morton Jonuschat updated the commit message in patch set 15 06/24/16, 18:02

  20. TYPO3com commented on patch set 15 06/24/16, 18:07 Completed build in 04m 47s on Fri, 24 Jun, 08:07 PM Test Summary: 9394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-195

  21. Georg Ringer voted on patch set 15 CR +1 V +1 06/27/16, 12:04

  22. Christian Kuhn commented on patch set 15 CR +1 V +1 06/27/16, 13:25

    ok, this patch should actually be safe to merge. let's do it.
  23. Susi Moog voted on patch set 15 CR +1 V +1 06/27/16, 13:39

  24. Christian Kuhn voted on patch set 15 CR +2 V +2 06/27/16, 13:40

  25. Gerrit merged patch set 15 06/27/16, 13:40