48561[BUGFIX] Index all file mounts in FAL indexer scheduler task
Commit message
Review
-
Code review CR +2
- Frans Saris +2
- Georg Ringer +1
- Stephan Großberndt +1
-
Verified V +2
- Frans Saris +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 2729
Show 4 earlier messages
-
Christian Kuhn updated the commit message in patch set 3 06/14/16, 12:45
-
Christian Kuhn commented on patch set 3 06/14/16, 12:46
Hey, i had to remove 6.2 from the list of requested backports: this is not a critical bug, so we must not touch 6.2 for this. -
DMK E-BUSINESS GmbH commented on patch set 3 06/14/16, 12:50
Please backport this patch to 6.2 as this is the version where I found the bug and where I need it to be fixed. -
Stephan Großberndt commented on patch set 3 06/14/16, 12:52
I agree, this should be backported. -
Frans Saris commented on patch set 3 CR +1 V +1 06/17/16, 09:31
This is an regression fix introduced by https://review.typo3.org/#/c/39787/ I'm for backporting this to 6.2 -
Frans Saris commented on patch set 3 06/17/16, 09:35
correction, no regression. Looks like this was already there for a long time -
Nicole Hummel commented on patch set 3 06/17/16, 09:44
@Christian: What would be the way to solve the issue in 6.2? IMHO having an indexer task which does not index is critical as it might give unexpected sides affects on the frontend page. -
Frank Nägler commented on patch set 3 CR +1 06/17/16, 09:47
code wise I am fine. But I agree to not backporting this fix. Yes, it is a bugfix, but it also change the behavior, which is a possible breaking change. The patch is very simple, so people who need this fix in 6.2, can patch the installation very easy. -
Stephan Großberndt commented on patch set 3 06/17/16, 09:49
Although this is not a regression it cleary is a bug - and even if it's a long-standing one, maybe others just did not notice yet the indexer did only index the first storage. Either we need the possibility to select the storages to index, which is a feature, which would probably not be backported or the indexer has to index all storages. I am in favor of simply backporting to 6.2 here and consider an additional feature for 8 to be able to select the storages to index. -
Nicole Hummel commented on patch set 3 06/17/16, 10:05
@Stephan: IMHO even if you would select a storage in the task, the file mounts of the cli user would be taken into account which would still result in not indexed files of a storage -
Nicole Hummel commented on patch set 3 06/17/16, 10:06
Just a question coming to my mind: do we really want to enforce patched (supported) cores for a working TYPO3 instance? -
Frans Saris commented on patch set 3 07/08/16, 09:02
IMO this is critical enough to backport to 6.2 It is a very hidden bug that can lead to a lot of headache and frustration -
Stephan Großberndt voted on patch set 3 CR +1 07/08/16, 09:46
-
Stephan Großberndt commented on patch set 3 CR 0 07/08/16, 09:47
Hm, our +1 do not include a "Releases: master, 7.6, 6.2" yet. -
Christian Kuhn commented on patch set 3 07/09/16, 11:18
ok, fine for 6.2 backport with me if this patch is clearly save and doesn't harm. -
Christian Kuhn updated the commit message in patch set 4 07/09/16, 11:21
-
Christian Kuhn rebased onto patch set 5 07/09/16, 11:21
-
TYPO3com voted on patch set 4 V +1 07/09/16, 11:29 Completed build in 07m 33s on Sat, 9 Jul, 01:29 PM Test Summary: 18406 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-641
-
TYPO3com voted on patch set 5 V +1 07/09/16, 11:32 Completed build in 10m 15s on Sat, 9 Jul, 01:32 PM Test Summary: 18406 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-642
-
Stephan Großberndt voted on patch set 5 CR +1 07/09/16, 11:36
-
Georg Ringer voted on patch set 5 CR +1 V +1 07/09/16, 17:54
-
Frans Saris voted on patch set 5 CR +2 V +2 07/11/16, 09:50
-
Gerrit merged patch set 5 07/11/16, 09:50
-
Frans Saris commented on patch set 6 07/11/16, 09:51
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit bd7740c5013937b23fd375b5ca2e4bdc85788020 -
Frans Saris commented on patch set 6 07/11/16, 11:08
@stephan could you maybe test the 6.2 version? https://review.typo3.org/#/c/48894/2