Review main Merged

48585[BUGFIX] EXT:form - Fix PHP warning in debug mode

Ralf Zimmermann CR +2 V +2 Normal +27 −24 updated 08/18/16, 19:02

Commit message

Avoid PHP warning on empty filters configuration.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Björn Jacob +1
    • Wouter Wolters +1
  • Verified V +2
    • Frank Nägler +2
    • Björn Jacob +1
    • Wouter Wolters +1

Issues 1

Files 1

Review log 9

  1. Ralf Zimmermann uploaded patch set 1 06/15/16, 10:49

  2. Björn Jacob updated the commit message in patch set 2 06/15/16, 10:57

  3. Wouter Wolters voted on patch set 2 CR +1 V +1 06/15/16, 13:16

  4. Björn Jacob voted on patch set 2 CR +1 V +1 06/15/16, 14:34

  5. Frank Nägler voted on patch set 2 CR +1 06/17/16, 07:38

  6. Frank Nägler voted on patch set 2 CR +2 V +2 06/17/16, 07:39

  7. Gerrit merged patch set 2 06/17/16, 07:39

  8. Stephan Großberndt commented on patch set 3 08/18/16, 12:04

    backport to 7.6 is missing. please add a note to the review if this is not going to be backported.
  9. Frank Nägler commented on patch set 3 08/18/16, 19:02

    no backport to 7.6, the problem can not occurs in 7.6 because the array could never be empty.