Review main Merged

48591[BUGFIX] Handle missing option values in CHECKBOXGROUP and RADIOGROUP

Andreas Häfner CR +2 V +2 Easy +10 −2 updated 06/29/16, 11:21

Commit message

Options are now checked for missing values and empty values are
inserted instead.

In rebuild process RADIOGROUP and CHECKBOXGROUP for every listed option
a single RADIO/CHECKBOX element is created by its xtype-configuration.
These elements rely on a passed value attribute. To prevent errors,
triggered by missing value attributes, a check for existence of the
attribute was introduced. In case of missing value, now an empty value
is used.
This change only influences the display process of the wizard.
Generation of Form-Configuration is not changed.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Björn Jacob +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 78

  1. Andreas Häfner uploaded patch set 1 06/16/16, 11:34

  2. Wouter Wolters updated the commit message in patch set 2 06/20/16, 21:03

  3. Wouter Wolters voted on patch set 2 CR +1 06/20/16, 21:07

  4. TYPO3com voted on patch set 2 V +1 06/20/16, 21:36 Build completed at: https://bamboo.typo3.com/browse/CORE-GTC-82

  5. Björn Jacob commented on patch set 2 CR +1 V +1 06/28/16, 10:41

    I've also added a small example on how to test this issue.
  6. Christian Kuhn voted on patch set 2 CR +2 V +2 06/29/16, 11:20

  7. Gerrit merged patch set 2 06/29/16, 11:20

  8. Christian Kuhn commented on patch set 3 06/29/16, 11:21

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 5f1d3987bddab018ab14605bd929c8886bc21ebf