Review main Abandoned

48608[BUGFIX] workspaces show all non deleted inline childs

Andreas Allacher CR 0 V 0 Easy +3 −1 updated 12/09/16, 08:37

Commit message

Currently there are no inline childs shown
if any inline child has VersionState::DELETE_PLACEHOLDER

This bugfix ensures that non deleted records
are still shown

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 14

  1. Andreas Allacher uploaded patch set 1 06/20/16, 09:26

  2. Andreas Allacher uploaded patch set 2 06/20/16, 10:26

  3. Andreas Allacher commented on patch set 2 06/20/16, 10:27

    TcaInline.php:183

    Otherwise in translation mode select deleted records are also displayed.
  4. Andreas Allacher uploaded patch set 3 06/20/16, 10:28

  5. Andreas Allacher uploaded patch set 4 06/20/16, 10:32

  6. Tim Wehrmann commented on patch set 4 CR +1 08/02/16, 15:13

    On my local machine, this works. Tested in default language on TYPO3 7.6.10
  7. Dominique Kreemers voted on patch set 4 CR +1 V +1 08/15/16, 15:54

  8. Oliver Hader voted on patch set 4 CR +1 08/15/16, 18:23

  9. Susi Moog commented on patch set 4 12/03/16, 18:31

    I wasn't able to reproduce this bug with the description from the ticket, is it still valid?
  10. Andreas Allacher commented on patch set 4 12/03/16, 20:16

    According to Sascha Schieferdecker in the ticket it still is. I haven't tested it myself. I rarely use workspaces. And as the change seems to be without merge issues, it is probably still valid. If you check the code changes currently getWorkspacedUids returns an empty array as soon as any inline record has been set to be deleted in the workspace. The easist way to reproduce should be to add to images to a content element (I think the best way to test it is to do so in the default language). Then switch to the workspace, delete one of those images, save and close the content element. Then reopen it and without the patch all images should be gone. I think the patch also fixes another issue and that is that if inline records were deleted in the workspace in another language than the default language, they were still shown as those weren't taken into account at all.
  11. Susi Moog commented on patch set 4 V -1 12/04/16, 08:22

    Found out why I could not reproduce the issue; it was already fixed by https://review.typo3.org/#/c/49723/2 - as that patch only contains the continue line could you have a look whether the other two lines of this patch are still necessary?
  12. Oliver Hader commented on patch set 4 CR -1 12/08/16, 20:56

    Cannot reproduce since this was already solved for master and 7.6
  13. Oliver Hader abandoned the change 12/08/16, 20:56

    Solved
  14. Andreas Allacher commented on patch set 4 12/09/16, 08:37

    The other two lines are necessary to ensure deleted files in translations are not shown inside workspaces. If you now have two languages and images in a content-element in the non-default language. Now if you delete one of those images and save the content element in the non-default language, you will see that the image is still visible. That is why the other tow lines existed. Not sure if that hasn't been fixed with another ticket. If not, we should create a new ticket for that and move the corresponding changes there.