Review main Merged

48615[TASK] Show case sensitive command identifier

Georg Ringer CR +2 V +2 Easy +6 −6 updated 08/05/16, 10:11

Commit message

Instead of using strtolower() use the names of the commands as
provided by the CommandController. This improves the readability
a lot.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1011

  1. Georg Ringer uploaded patch set 1 06/20/16, 17:48

  2. TYPO3com voted on patch set 1 V +1 06/20/16, 18:01 Build completed at: https://bamboo.typo3.com/browse/CORE-GTC-71

  3. Wouter Wolters commented on patch set 1 CR +1 V +1 07/20/16, 13:12

    I like it.
  4. Benni Mack voted on patch set 1 CR +2 V +2 07/20/16, 21:18

  5. Gerrit merged patch set 1 07/20/16, 21:18

  6. Helmut Hummel commented on patch set 2 08/01/16, 16:20

    post -1 First of all, this is a breaking change! There are other extensions using this API and they now get a different identifier back than before. second: which commands are not readable? these should be shortened instead. imho showing cased identifiers while accepting any casing is confusing at least. besides that: this commit broke the special handling of the "help" command, which is now shown as "Help:help"
  7. Helmut Hummel commented on patch set 2 08/01/16, 16:24

    is there any command line tool, that uses cased command identifiers? I know none. making TYPO3 exceptional here (again)?
  8. Helmut Hummel commented on patch set 2 08/01/16, 16:26

    and on top: it might make things more complicated for the future. previously the only official command was lowercased (although wrong casing was accepted). Now we officially support different casing for commands. symfony console does not
  9. Benni Mack commented on patch set 2 08/02/16, 06:00

    wow. thanks for the analysis. did not see this gravital impact, and I opt for reverting. @georg OK?
  10. Helmut Hummel commented on patch set 2 08/02/16, 11:02

    For better readability, I would suggest the following change: https://github.com/TYPO3-Console/typo3_console/issues/270 I have a PoC ready for typo3 console and it works like a charm.
  11. Wouter Wolters commented on patch set 2 08/05/16, 10:11

    Reverted This patchset was reverted in change: Ie1762c3192ab10682f0c2ad303e6577ee3780798