Review main Merged

48634[TASK] Add karma-coverage and karma-junit-reporter

Susi Moog CR +2 V +2 Easy +17 −2 updated 06/23/16, 11:56

Commit message

To get junit compatible results and code coverage
reports that can be understood by CI systems this
patch adds dependencies to karma-coverage and
karma-junit-reporter. It also adds the necessary configuration.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • Helmut Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1

Issues 1

Files 2

Review log 1213

  1. Susi Moog uploaded patch set 1 06/22/16, 10:47

  2. Wouter Wolters voted on patch set 1 CR +1 06/22/16, 10:53

  3. Andreas Kienast voted on patch set 1 CR +1 06/22/16, 10:54

  4. Frank Nägler voted on patch set 1 CR +1 06/22/16, 10:55

  5. TYPO3com voted on patch set 1 V +1 06/22/16, 11:02 Build completed at: https://bamboo.typo3.com/browse/CORE-GTC-100

  6. Helmut Hummel commented on patch set 1 06/22/16, 17:50

    karma.conf.js:41

    can we use a subdirecrtory of typo3temp here? something like typo3temp/vat/tests

    karma.conf.js:48

    same here
  7. Susi Moog uploaded patch set 2 06/22/16, 19:00

  8. Susi Moog commented on patch set 1 06/22/16, 19:01

    karma.conf.js:41 Reply

    yes we can!

    karma.conf.js:48 Reply

    Done
  9. Frank Nägler voted on patch set 2 CR +1 06/22/16, 19:03

  10. Frank Nägler voted on patch set 2 V +1 06/22/16, 19:15

  11. Helmut Hummel commented on patch set 2 CR +1 06/23/16, 09:25

    Thanks!
  12. Christian Kuhn voted on patch set 2 CR +2 V +2 06/23/16, 11:56

  13. Gerrit merged patch set 2 06/23/16, 11:56