Review main Merged

48662[TASK] Deprecate 3rd parameter of pi_getLL

Wouter Wolters CR +2 V +2 Normal +79 −63 updated 05/05/17, 14:20

Commit message

Review

  • Code review CR +2
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 811

  1. Wouter Wolters uploaded patch set 1 06/23/16, 19:24

  2. TYPO3com voted on patch set 1 V +1 06/23/16, 19:33 Completed build in 09m 19s on Thu, 23 Jun, 09:33 PM Test Summary: 9364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-157

  3. Wouter Wolters uploaded patch set 2 06/23/16, 19:39

  4. TYPO3com voted on patch set 2 V +1 06/23/16, 19:51 Completed build in 12m 29s on Thu, 23 Jun, 09:51 PM Test Summary: 9379 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-158

  5. Michael Oehlhof commented on patch set 2 06/26/16, 12:41

    Deprecation-71917-DeprecateTheArgumentHscForGetLLGetLLLAndSL.rst:17

    There must be 2 empty lines.
  6. Benni Mack commented on patch set 3 06/27/16, 05:06

    Published edit on patch set 2.
  7. Benni Mack voted on patch set 3 CR +1 V +1 06/27/16, 05:08

  8. TYPO3com voted on patch set 3 V +1 06/27/16, 05:14 Completed build in 08m 11s on Mon, 27 Jun, 07:14 AM Test Summary: 9611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-258

  9. Georg Ringer voted on patch set 3 CR +2 V +2 06/27/16, 11:50

  10. Gerrit merged patch set 3 06/27/16, 11:50

  11. Markus Klein commented on patch set 4 05/05/17, 14:20

    AbstractPlugin.php:586

    AbstractPlugin.php:605