Review main Merged

48663[BUGFIX] Field is not added to TCA if part of fieldname exists

Wouter Wolters CR +2 V +2 Easy +18 −1 updated 07/02/16, 21:37

Commit message

Explode current showitem and check if new field is already
available instead of using a wrong strpos check.

Review

  • Code review CR +2
    • Markus Klein +2
    • Christian Kuhn +1
    • Jörg Bösche +1
  • Verified V +2
    • Markus Klein +2
    • Christian Kuhn +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1113

  1. Wouter Wolters uploaded patch set 1 06/23/16, 21:47

  2. TYPO3com voted on patch set 1 V -1 06/23/16, 21:55 Completed build in 07m 19s on Thu, 23 Jun, 11:55 PM Test Summary: 1 of 9365 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-159

  3. Wouter Wolters uploaded patch set 2 06/24/16, 06:51

  4. TYPO3com voted on patch set 2 V +1 06/24/16, 06:58 Completed build in 07m 21s on Fri, 24 Jun, 08:58 AM Test Summary: 9365 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-160

  5. Jörg Bösche voted on patch set 2 CR +1 06/27/16, 21:02

  6. Christian Kuhn commented on patch set 2 CR +1 V +1 06/28/16, 17:27

    wouter, do you insist on 6.2 backport, or could we maybe leave this out?
  7. Wouter Wolters commented on patch set 2 06/28/16, 17:32

    This is a big regression IMO. So yes I would backport it to 6.2. This regression was introduced with a performance change during 6.2
  8. Markus Klein commented on patch set 2 CR +1 06/28/16, 17:37

    I'm also +1 for 6.2 backport here. If I remember correctly we already had more than one regression with this "find something in a comma-separated list" changes.
  9. Christian Kuhn commented on patch set 2 06/29/16, 11:16

    ok, fine with me. so let's gather the last testing vote.
  10. Jörg Bösche voted on patch set 2 V +1 07/01/16, 06:41

  11. Markus Klein voted on patch set 2 CR +2 V +2 07/02/16, 21:36

  12. Gerrit merged patch set 2 07/02/16, 21:36

  13. Markus Klein commented on patch set 3 07/02/16, 21:37

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit dee1be6005d0ea0a2ba4f3dd6e19b4cb44f0277b