Review main Merged

48667[BUGFIX] Fix link to edit file metadata in full window

Wouter Wolters CR +2 V +2 Easy +3 −8 updated 07/27/16, 08:25

Commit message

When opening a window with a file reference in a full window
it is not possible to click the edit metadata button.

Use a normal href to avoid the issue with choosing the correct frame.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Frederic Gaus +1
    • Markus Klein +1
    • Michael Oehlhof +1
  • Verified V +2
    • Wouter Wolters +2
    • Frederic Gaus +1
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Wouter Wolters uploaded patch set 1 06/24/16, 09:48

  2. TYPO3com voted on patch set 1 V +1 06/24/16, 09:53 Completed build in 05m 13s on Fri, 24 Jun, 11:53 AM Test Summary: 9409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-169

  3. Riccardo De Contardi voted on patch set 1 V +1 06/24/16, 10:04

  4. Michael Oehlhof voted on patch set 1 CR +1 06/26/16, 12:34

  5. Markus Klein updated the commit message in patch set 2 07/12/16, 22:59

  6. TYPO3com voted on patch set 2 V +1 07/12/16, 23:08 Completed build in 07m 51s on Wed, 13 Jul, 01:08 AM Test Summary: 18450 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-901

  7. Michael Oehlhof voted on patch set 2 CR +1 07/22/16, 12:18

  8. Markus Klein voted on patch set 2 CR +1 V +1 07/23/16, 08:51

  9. Frederic Gaus voted on patch set 2 CR +1 V +1 07/25/16, 12:56

  10. Wouter Wolters voted on patch set 2 CR +2 V +2 07/27/16, 08:25

  11. Gerrit merged patch set 2 07/27/16, 08:25

  12. Wouter Wolters commented on patch set 3 07/27/16, 08:25

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit b2ab731b5a1ffc093681f5a3969bed64309ed430