48669[BUGFIX] Fix JavaScript errors when opening filelist in full window
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 5
- typo3/sysext/filelist/Classes/Controller/FileListController.php+1 −0
- typo3/sysext/filelist/Classes/FileList.php+29 −12
- typo3/sysext/filelist/Resources/Private/Templates/FileList/Search.html+9 −4
- typo3/sysext/filelist/Resources/Public/JavaScript/FileDelete.js+4 −7
- typo3/sysext/filelist/Resources/Public/JavaScript/FileList.js+34 −26
Review log 1216
-
Wouter Wolters uploaded patch set 1 06/24/16, 11:36
-
TYPO3com voted on patch set 1 V +1 06/24/16, 11:43 Completed build in 06m 39s on Fri, 24 Jun, 01:43 PM Test Summary: 9394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-171
-
Riccardo De Contardi commented on patch set 1 V -1 06/25/16, 20:03
- rename works on file list but not on context menu ("Uncaught TypeError: Cannot read property 'list_frame' of undefined") even when working, a javascript error is thrown on save ("Uncaught TypeError: Cannot read property 'NavigationIframe' of undefined") - preview does not work ("Uncaught TypeError: top.openUrlInWindow is not a function") - edit does not work ("Uncaught TypeError: Cannot read property 'list_frame' of undefined") - editing the content of a text file works, but the close button does not ("Uncaught TypeError: top.goToModule is not a function") -
Wouter Wolters commented on patch set 1 06/29/16, 17:41
While I agree that these are errors too, I only changed the list_frame failures with this patch. The ClickMenu needs a different patch. I continue on this on friday. -
Wouter Wolters uploaded patch set 2 09/02/16, 09:51
-
TYPO3com voted on patch set 2 V -1 09/02/16, 09:54 Completed build in 03m 02s on Fri, 2 Sep, 11:54 AM Test Summary: 18499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2717
-
Wouter Wolters uploaded patch set 3 09/02/16, 09:58
-
TYPO3com voted on patch set 3 V +1 09/02/16, 10:01 Completed build in 03m 04s on Fri, 2 Sep, 12:01 PM Test Summary: 18499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2718
-
Riccardo De Contardi commented on patch set 3 V -1 09/02/16, 10:16
- rename works on file list but not on context menu ("Uncaught TypeError: Cannot read property 'list_frame' of undefined") - info does not work ("Uncaught TypeError: Cannot read property 'moduleUrl' of undefined") - info on context menu does not work ("Uncaught TypeError: top.launchView is not a function") - edit does not work "Uncaught SyntaxError: Unexpected token <" and "Uncaught TypeError: Cannot read property 'hierarchy' of undefined" - edit does not work on contenxt menu ("Uncaught TypeError: Cannot read property 'list_frame' of undefined") - editing the content of a text file works, but the close button does not ("Uncaught TypeError: top.goToModule is not a function") - editing the content of a text file does not work on contenxt menu ("Uncaught TypeError: Cannot read property 'list_frame' of undefined") -
Andreas Kienast uploaded patch set 4 10/12/16, 20:49
-
TYPO3com voted on patch set 4 V +1 10/12/16, 20:55 Completed build in 05m 13s on Wed, 12 Oct, 10:55 PM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3682
-
Riccardo De Contardi commented on patch set 4 V -1 10/12/16, 21:11
1) On the main window (same as CMS) clicking on file (edit metadata):works - edit content: works - show: works - replace:works - rename:works - info: does not work (Uncaught TypeError: Cannot read property 'moduleUrl' of undefined) - copy:works - cut: works context menu: - edit: does not work (Uncaught TypeError: Cannot read property 'list_frame' of undefined) - edit content: does not work (Uncaught TypeError: Cannot read property 'list_frame' of undefined) - rename: does not work (Uncaught TypeError: Cannot read property 'list_frame' of undefined) - info:works - cut:works - copy:works - delete: does not work (Uncaught TypeError: Cannot read property 'list_frame' of undefined) 2) opened on new window: clicking on file (edit metadata):works - edit content: works - show: works - replace:works (note: when clicking on cancel it throws an error "Uncaught TypeError: top.goToModule is not a function" but it disappears) - rename:works (note: when clicking on cancel it throws an error "Uncaught TypeError: top.goToModule is not a function" but it disappears) - info: does not work (Uncaught TypeError: Cannot read property 'moduleUrl' of undefined) context menu: - edit: does not work (Uncaught TypeError: Cannot read property 'list_frame' of undefined) - edit content: does not work (Uncaught TypeError: Cannot read property 'list_frame' of undefined) - rename: does not work (Uncaught TypeError: Cannot read property 'list_frame' of undefined) - info: does not work (Uncaught TypeError: top.launchView is not a function) - cut:works - copy:works - delete: does not work (Uncaught TypeError: Cannot read property 'list_frame' of undefined) -
Benni Mack commented on patch set 4 CR -1 10/18/16, 08:13
should be fixed by changing the "name" attribute of the iframe in EXT:backend/Resources/Private/Templates/Backend/Main.html" -
Benni Mack commented on patch set 4 10/27/16, 15:54
hey wouter, so we only need this for 7.6 now, right? -
Wouter Wolters commented on patch set 4 10/27/16, 16:28
Will check that later tonight. -
Wouter Wolters abandoned the change 11/08/16, 17:43
Not needed for master anymore.