Review main Merged

48670[BUGFIX] Only clear cache if you have access to the page

Wouter Wolters CR +2 V +2 Easy +12 −7 updated 07/04/16, 19:42

Commit message

Review

  • Code review CR +2
    • Georg Ringer +2
    • Jigal van Hemert +1
  • Verified V +2
    • Georg Ringer +2
    • Jigal van Hemert +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1722

  1. Wouter Wolters uploaded patch set 1 06/24/16, 12:19

  2. TYPO3com voted on patch set 1 V +1 06/24/16, 12:23 Completed build in 04m 10s on Fri, 24 Jun, 02:23 PM Test Summary: 9394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-173

  3. Nicole Hummel voted on patch set 1 CR +1 06/24/16, 12:26

  4. Nicole Hummel commented on patch set 1 06/24/16, 12:30

    ExtdirectTreeCommands.php:172

    would rename to $dataHandler
  5. Nicole Hummel commented on patch set 2 06/24/16, 12:32

    Published edit on patch set 1.
  6. Nicole Hummel voted on patch set 2 CR +1 06/24/16, 12:32

  7. Wouter Wolters uploaded patch set 3 06/24/16, 12:37

  8. Wouter Wolters uploaded patch set 4 06/24/16, 12:37

  9. TYPO3com voted on patch set 2 V +1 06/24/16, 12:39 Completed build in 06m 56s on Fri, 24 Jun, 02:39 PM Test Summary: 9394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-174

  10. Nicole Hummel commented on patch set 4 06/24/16, 12:42

    PageLayoutController.php:482

    !empty($this->pageinfo)
  11. TYPO3com voted on patch set 3 V +1 06/24/16, 12:44 Completed build in 07m 00s on Fri, 24 Jun, 02:44 PM Test Summary: 9394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-175

  12. TYPO3com voted on patch set 4 V +1 06/24/16, 12:47 Completed build in 06m 21s on Fri, 24 Jun, 02:47 PM Test Summary: 9394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-176

  13. Wouter Wolters commented on patch set 4 06/24/16, 12:51

    PageLayoutController.php:482 Reply

    this can either be an array or false.
  14. Michael Oehlhof voted on patch set 4 CR +1 06/26/16, 12:23

  15. Nicole Hummel commented on patch set 4 06/26/16, 15:57

    PageLayoutController.php:482 Reply

    IMHO !empty(false) is better that `array` in if clause
  16. Jigal van Hemert uploaded patch set 5 07/04/16, 19:35

  17. TYPO3com voted on patch set 5 V +1 07/04/16, 19:38 Completed build in 02m 43s on Mon, 4 Jul, 09:38 PM Test Summary: 9651 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-444

  18. Jigal van Hemert commented on patch set 5 CR +1 V +1 07/04/16, 19:39

    The empty() function works fine on false and empty arrays.
  19. Georg Ringer voted on patch set 5 CR +2 V +2 07/04/16, 19:41

  20. Gerrit merged patch set 5 07/04/16, 19:41

  21. Wouter Wolters commented on patch set 5 07/04/16, 19:41

    If you change the code please use the same structure in all places the code touches now
  22. Wouter Wolters commented on patch set 5 07/04/16, 19:42

    post -1!