Review main Merged

48695[TASK] Add unit tests to apcu cache backend

Christian Kuhn CR +2 V +2 Hard +304 −0 updated 06/29/16, 18:20

Commit message

When the apcu backend was introduced unit tests were missing.
The patch adds tests similar to the apc tests.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 912

  1. Christian Kuhn uploaded patch set 1 06/27/16, 16:02

  2. Christian Kuhn commented on patch set 1 CR -1 06/27/16, 16:03

    -1 for the moment.
  3. TYPO3com voted on patch set 1 V +1 06/27/16, 16:05 Completed build in 02m 34s on Mon, 27 Jun, 06:05 PM Test Summary: 9611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-269

  4. Christian Kuhn uploaded patch set 2 06/28/16, 12:00

  5. TYPO3com voted on patch set 2 V +1 06/28/16, 12:03 Completed build in 02m 31s on Tue, 28 Jun, 02:03 PM Test Summary: 9611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-280

  6. Christian Kuhn voted on patch set 2 CR -1 06/28/16, 14:49

  7. Christian Kuhn rebased onto patch set 3 06/28/16, 15:35

  8. TYPO3com voted on patch set 3 V +1 06/28/16, 15:47 Completed build in 10m 53s on Tue, 28 Jun, 05:47 PM Test Summary: 9641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-302

  9. Christian Kuhn commented on patch set 3 CR +1 V +1 06/28/16, 15:49

    This should be good to go now: apcu is now loaded on the bamboo agents and the build verifies those new tests are green :)
  10. Wouter Wolters voted on patch set 3 CR +1 06/28/16, 17:40

  11. Wouter Wolters commented on patch set 3 CR +2 V +2 06/29/16, 18:20

    Checked that Bamboo is green with this change.
  12. Gerrit merged patch set 3 06/29/16, 18:20