48700[BUGFIX] Strip trailing slash from parsed doc comment
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Markus Klein +1
-
Verified V +2
- Jigal van Hemert +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2024
-
Helmut Hummel uploaded patch set 1 06/28/16, 07:40
-
Andreas Kienast updated the commit message in patch set 2 06/28/16, 07:42
-
Andreas Kienast voted on patch set 2 CR +1 06/28/16, 07:42
-
TYPO3com voted on patch set 1 V +1 06/28/16, 07:43 Completed build in 03m 03s on Tue, 28 Jun, 09:43 AM Test Summary: 9612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-274
-
Wouter Wolters voted on patch set 2 CR +1 06/28/16, 07:44
-
TYPO3com voted on patch set 2 V +1 06/28/16, 07:45 Completed build in 02m 55s on Tue, 28 Jun, 09:45 AM Test Summary: 9612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-275
-
Markus Klein commented on patch set 2 06/28/16, 09:09
-
Markus Klein commented on patch set 2 06/28/16, 09:16
DocCommentParser.php:52ReplyThe new regex would be: #\\s*/?[\\*/]*(.*)$# -
Jigal van Hemert commented on patch set 2 06/28/16, 09:51
DocCommentParser.php:52Reply#\\s*/?[*/]*(.*)$# is enough; there won't be any backslashes before the description. -
Markus Klein commented on patch set 2 06/28/16, 10:11
DocCommentParser.php:52ReplyJigal, I'm not sure why those backslashes were added there, that's why I kept them. Assuming that somebody didn't know about how escaping in character classes works, those are for sure superfluous. -
Helmut Hummel commented on patch set 2 06/28/16, 10:52
DocCommentParser.php:52ReplyMight be. Feel free to improve. However make sure the test still passes and no additional (empty) new line is added -
Helmut Hummel uploaded patch set 3 06/28/16, 11:05
-
Helmut Hummel commented on patch set 2 06/28/16, 11:05
DocCommentParser.php:52This trim will remove empty new lines anyway, so changing the regex is more elegant -
TYPO3com voted on patch set 3 V +1 06/28/16, 11:08 Completed build in 02m 36s on Tue, 28 Jun, 01:08 PM Test Summary: 9612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-279
-
Markus Klein commented on patch set 3 CR +1 06/28/16, 11:17
DocCommentParser.php:49So the last remaining question. Can there be a backslash at the beginning of a line that must not be captured? Otherwise I opt for removing this as well. -
Helmut Hummel commented on patch set 3 06/30/16, 11:44
> Can there be a backslash at the beginning of a line that must not be captured? So shall we wait until magically an answer appears, or just merge the bugfix first? ;) I'd opt for merging this and see if we stumble upon further issues later :) -
Jigal van Hemert commented on patch set 3 06/30/16, 11:52
> > Can there be a backslash at the beginning of a line that must not > be captured? > > So shall we wait until magically an answer appears, or just merge > the bugfix first? ;) > > I'd opt for merging this and see if we stumble upon further issues > later :) Answer: no, there not be a backslash at the beginning of a line that must not be captured. Backslashes in character classes are in 98 out of 80 cases the result of brains not understanding which characters need to be escaped in which case. I'd say: exit with the backslashes. -
Markus Klein commented on patch set 4 06/30/16, 16:52
Published edit on patch set 3. -
Markus Klein voted on patch set 4 CR +1 V +1 06/30/16, 16:52
-
TYPO3com voted on patch set 4 V +1 06/30/16, 16:58 Completed build in 05m 21s on Thu, 30 Jun, 06:58 PM Test Summary: 9645 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-355
-
Jigal van Hemert voted on patch set 4 CR +2 V +2 06/30/16, 19:46
-
Gerrit merged patch set 4 06/30/16, 19:46
-
Jigal van Hemert commented on patch set 5 06/30/16, 19:47
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 98617d9ced9450596d4ff1dc8a13a1cfed849bb3 -
Helmut Hummel commented on patch set 5 06/30/16, 20:23
Thanks!
DocCommentParser.php:52