Review main Merged

48710[BUGFIX] Wrong expectException() order in ApcBackendTest

Christian Kuhn CR +2 V +2 Easy +2 −3 updated 06/28/16, 15:26

Commit message

expectException() has to be called before calling
system under test.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 711

  1. Christian Kuhn uploaded patch set 1 06/28/16, 15:04

  2. Christian Kuhn updated the commit message in patch set 2 06/28/16, 15:05

  3. Christian Kuhn commented on patch set 2 06/28/16, 15:06

    will merge if bamboo gives green light.
  4. TYPO3com voted on patch set 1 V -1 06/28/16, 15:08 Completed build in 04m 12s on Tue, 28 Jun, 05:08 PM Test Summary: 1 of 9626 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-289

  5. TYPO3com voted on patch set 2 V -1 06/28/16, 15:11 Completed build in 05m 48s on Tue, 28 Jun, 05:11 PM Test Summary: 1 of 9626 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-290

  6. Christian Kuhn uploaded patch set 3 06/28/16, 15:16

  7. Christian Kuhn commented on patch set 2 06/28/16, 15:17

    oh, exceptionCode was wrong, too. adapted now.
  8. TYPO3com voted on patch set 3 V +1 06/28/16, 15:19 Completed build in 02m 27s on Tue, 28 Jun, 05:19 PM Test Summary: 9626 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-291

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 06/28/16, 15:20

  10. Gerrit merged patch set 3 06/28/16, 15:20

  11. TYPO3com commented on patch set 2 06/28/16, 15:26 Completed build in 26m 47s on Tue, 28 Jun, 05:26 PM Test Summary: 1 of 9626 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-290