4872[TASK] EM: make pop-up window use full screen
Commit message
Review
-
Code review CR +2
- Francois Suter +2
- Xavier Perseguers +1
-
Verified V +2
- Francois Suter +2
- Xavier Perseguers +1
- Soren Malling +1
Issues 1
Files 1
Review log 7
-
Francois Suter commented on patch set 1 09/09/11, 12:48
I agree that the close button seems a bit tiny, but I would prefer to handle that in a separate patch, if someone really feels the need. The proposed change at least vastly improves the usability of the EM (IMO) and I would quite like to have it in first. -
Francois Suter commented on patch set 1 V 0 09/09/11, 12:48
by team member; Looks good to me, approved -
Xavier Perseguers commented on patch set 1 09/09/11, 12:48
Verified; Looks good to me, but someone else must approve -
Soren Malling commented on patch set 1 09/09/11, 12:48
I like the concept, but it's feeling overwhelmingly when all the other extensions "are gone", and the only way back is a little close icon in the upper right corner. Could a "Get back" be made more visible? -
Soren Malling voted on patch set 1 V 0 09/09/11, 12:48
-
Mr. Jenkins commented on patch set 1 09/09/11, 12:48
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1802/ : SUCCESS -
Francois Suter merged patch set 1 09/09/11, 12:48