Review main Merged

4872[TASK] EM: make pop-up window use full screen

Francois Suter CR +2 V +2 Easy +1 −2 updated 06/03/13, 20:49

Commit message

The information pop-up window in the Extension Manager is hard-coded
to some reduced size. Make it use the full screen instead, as it is
modal anyway. This provides more space to view all the information.

Review

  • Code review CR +2
    • Francois Suter +2
    • Xavier Perseguers +1
  • Verified V +2
    • Francois Suter +2
    • Xavier Perseguers +1
    • Soren Malling +1

Issues 1

Files 1

Review log 7

  1. Francois Suter commented on patch set 1 09/09/11, 12:48

    I agree that the close button seems a bit tiny, but I would prefer to handle that in a separate patch, if someone really feels the need. The proposed change at least vastly improves the usability of the EM (IMO) and I would quite like to have it in first.
  2. Francois Suter commented on patch set 1 V 0 09/09/11, 12:48

    by team member; Looks good to me, approved
  3. Xavier Perseguers commented on patch set 1 09/09/11, 12:48

    Verified; Looks good to me, but someone else must approve
  4. Soren Malling commented on patch set 1 09/09/11, 12:48

    I like the concept, but it's feeling overwhelmingly when all the other extensions "are gone", and the only way back is a little close icon in the upper right corner. Could a "Get back" be made more visible?
  5. Soren Malling voted on patch set 1 V 0 09/09/11, 12:48

  6. Mr. Jenkins commented on patch set 1 09/09/11, 12:48

  7. Francois Suter merged patch set 1 09/09/11, 12:48