48723[!!!][TASK] Make AbstractConditionViewHelper::evaluateCondition public
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/master/Breaking-76874-MethodEvaluateConditionOnAbstractConditionViewHelperNowPublic.rstnew+32 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Security/IfAuthenticatedViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Security/IfHasRoleViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Security/IfAuthenticatedViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Security/IfHasRoleViewHelper.php+1 −1
Review log 56
-
Claus Due uploaded patch set 1 06/29/16, 15:35
-
TYPO3com voted on patch set 1 V +1 06/29/16, 15:37 Completed build in 02m 29s on Wed, 29 Jun, 05:37 PM Test Summary: 9626 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-313
-
Wouter Wolters commented on patch set 1 06/29/16, 18:32
Should wait after the 8.2 release. -
Benni Mack voted on patch set 1 CR +1 07/11/16, 09:34
-
Claus Due commented on patch set 1 07/25/16, 08:43
Can be merged now, if you agree about the vision? -
Claus Due abandoned the change 11/14/16, 11:41
Abandoned; extremely low priority, very low performance impact - and can probably be remedied as part of another plan to remove the semi-duplicated non-static evaluation methods from the condition ViewHelper base class.