Review main Abandoned Breaking

48723[!!!][TASK] Make AbstractConditionViewHelper::evaluateCondition public

Claus Due CR 0 V 0 Easy +36 −4 updated 11/14/16, 11:41

Commit message

This change makes the visibility of ``evaluateCondition`` on
AbstractConditionViewHelper ``public`` (was ``protected``).
Necessary precursor for calling this method directly from compiled
templates to make all condition ViewHelpers perform better.

Related to #73565 but cannot be cherry-picked to LTS branch due
to significant differences in affected classes - and will not by
itself completely solve the issue described in that other report.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 56

  1. Claus Due uploaded patch set 1 06/29/16, 15:35

  2. TYPO3com voted on patch set 1 V +1 06/29/16, 15:37 Completed build in 02m 29s on Wed, 29 Jun, 05:37 PM Test Summary: 9626 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-313

  3. Wouter Wolters commented on patch set 1 06/29/16, 18:32

    Should wait after the 8.2 release.
  4. Benni Mack voted on patch set 1 CR +1 07/11/16, 09:34

  5. Claus Due commented on patch set 1 07/25/16, 08:43

    Can be merged now, if you agree about the vision?
  6. Claus Due abandoned the change 11/14/16, 11:41

    Abandoned; extremely low priority, very low performance impact - and can probably be remedied as part of another plan to remove the semi-duplicated non-static evaluation methods from the condition ViewHelper base class.