Review main Merged Breaking

48756[!!!][TASK] Migrate syslog lowlevel command to Symfony Console

Benni Mack CR +2 V +2 Normal +150 −77 updated 07/07/16, 16:24

Commit message

The lowlevel cleaner syslog command is migrated to a Symfony
Command to show the latest sys_log entries on the command line.

The new command is called via

./typo3/sysext/core/bin/typo3 syslog:list

instead of the old way using

./typo3/cli_dispatch.phpsh lowlevel_cleaner syslog -r

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Oliver Hader +1
  • Verified V +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 89

  1. Benni Mack uploaded patch set 1 06/30/16, 15:40

  2. TYPO3com voted on patch set 1 V +1 06/30/16, 15:46 Completed build in 05m 53s on Thu, 30 Jun, 05:46 PM Test Summary: 9644 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-354

  3. Oliver Hader voted on patch set 1 CR +1 06/30/16, 16:15

  4. Wouter Wolters voted on patch set 1 CR +1 V +1 06/30/16, 20:41

  5. Mathias Brodala commented on patch set 1 07/01/16, 07:56

    Breaking-76891-SyslogLowlevelCommand.rst:10

    Why not simply "bin/typo3"? No matter how or what you install, if typo3/cms-core is installed (which is inevitable), you'll most likely have the command at this location. Otherwise at "vendor/bin/typo3".
  6. Benni Mack commented on patch set 1 07/07/16, 12:11

    @mathias: the typo3/sysext/core/bin/ variant is currently the safest, since the composer linking is not working ATM (I'm on that). So I hope it's ok for now.
  7. Mathias Brodala commented on patch set 1 07/07/16, 12:26

    > @mathias: the typo3/sysext/core/bin/ variant is currently the > safest, since the composer linking is not working ATM (I'm on > that). So I hope it's ok for now. Yes, I understand the issue so go ahead. :-)
  8. Anja Leichsenring voted on patch set 1 CR +2 V +2 07/07/16, 16:24

  9. Gerrit merged patch set 1 07/07/16, 16:24