Review main Merged Breaking

48762[!!!][TASK] Remove two unused properties from PageTreeView

Wouter Wolters CR +2 V +2 Easy +29 −10 updated 07/06/16, 22:04

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Sebastian Fischer +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 1417

  1. Wouter Wolters uploaded patch set 1 06/30/16, 21:18

  2. TYPO3com voted on patch set 1 V +1 06/30/16, 21:21 Completed build in 02m 48s on Thu, 30 Jun, 11:21 PM Test Summary: 9645 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-366

  3. Wouter Wolters uploaded patch set 2 07/01/16, 06:43

  4. TYPO3com voted on patch set 2 V +1 07/01/16, 06:45 Completed build in 02m 49s on Fri, 1 Jul, 08:45 AM Test Summary: 9645 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-367

  5. Mathias Brodala commented on patch set 2 07/01/16, 07:58

    Are you sure this is breaking? Writing to non-existing properties on objects simply works (always does in PHP), reading non-existing properties only yields a notice. (See https://3v4l.org/Y1IJo )
  6. Wouter Wolters commented on patch set 2 07/06/16, 10:53

    I mark it as breaking to make people aware of this change. Better be safe than sorry
  7. Andreas Kienast voted on patch set 2 CR +1 V +1 07/06/16, 12:02

  8. Markus Klein updated the commit message in patch set 3 07/06/16, 12:07

  9. Markus Klein commented on patch set 3 07/06/16, 12:08

    Breaking-76879-RemoveUnusedPropertiesFromPageTreeView.rst:29

    are those TSconfig options?
  10. Wouter Wolters commented on patch set 3 07/06/16, 12:13

    Breaking-76879-RemoveUnusedPropertiesFromPageTreeView.rst:29 Reply

    The properties were previously filled with the TSconfig options, both are not in use anymore. See also the Forge ticket.
  11. TYPO3com voted on patch set 3 V +1 07/06/16, 12:23 Completed build in 16m 08s on Wed, 6 Jul, 02:23 PM Test Summary: 9663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-496

  12. Sebastian Fischer voted on patch set 3 CR +1 07/06/16, 12:36

  13. Benni Mack commented on patch set 3 07/06/16, 12:54

    you can also remove $ajaxStatus as well in this round. Not in use anymore (since we don't have the old iframe anymore)
  14. Oliver Klee voted on patch set 3 CR +1 07/06/16, 13:37

  15. Georg Ringer voted on patch set 3 CR +1 V +1 07/06/16, 17:40

  16. Christian Kuhn commented on patch set 3 CR +2 V +2 07/06/16, 22:04

    obvious. i think it is ok if we do the the $ajaxStatus change with another patch.
  17. Gerrit merged patch set 3 07/06/16, 22:04