Review main Merged

48763[BUGFIX] Reset SYS/exceptionalErrors in live preset

Nicole Hummel CR +2 V +2 Easy +2 −0 updated 08/18/16, 12:06

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Daniel Goerz +1
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1011

  1. Nicole Hummel uploaded patch set 1 07/01/16, 07:40

  2. TYPO3com voted on patch set 1 V +1 07/01/16, 07:43 Completed build in 02m 39s on Fri, 1 Jul, 09:43 AM Test Summary: 9645 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-370

  3. Wouter Wolters voted on patch set 1 CR +1 07/01/16, 07:46

  4. Daniel Goerz voted on patch set 1 CR +1 V +1 07/01/16, 07:52

  5. Mathias Brodala commented on patch set 1 CR -1 07/01/16, 08:01

    LivePreset.php:46

    I'd vote for using "E_RECOVERABLE_ERROR | E_USER_DEPRECATED" on master here (thanks to PHP 7) and only using the raw integer values on 7.6 and 6.2.
  6. Mathias Brodala commented on patch set 1 07/01/16, 08:02

  7. Nicole Hummel commented on patch set 1 07/01/16, 08:22

    @Mathias: I'll vote for doing it the same way as in the debug preset ;-)
  8. Mathias Brodala commented on patch set 1 CR 0 07/01/16, 08:25

    OK, understood. But maybe we should change all occurrences of combined literal constant values in master after this change.
  9. Benni Mack voted on patch set 1 CR +2 V +2 07/06/16, 12:52

  10. Gerrit merged patch set 1 07/06/16, 12:54

  11. Stephan Großberndt commented on patch set 2 08/18/16, 12:06

    Backport to 6.2 is missing, please add a note to the review if this is not going to be backported.