Review main Merged

48764[TASK] Remove class alias usage from ext:fluid unit tests

Wouter Wolters CR +2 V +2 Normal +66 −45 updated 07/06/16, 13:28

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 19

Review log 78

  1. Wouter Wolters uploaded patch set 1 07/01/16, 08:59

  2. TYPO3com voted on patch set 1 V +1 07/01/16, 09:02 Completed build in 02m 49s on Fri, 1 Jul, 11:02 AM Test Summary: 9645 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-372

  3. Christian Kuhn commented on patch set 1 CR +1 V +1 07/01/16, 16:47

    AbstractWidgetViewHelperTest.php:18

    hint: this is yellow in storm and class does not exist ... maybe other patch, it seems to be used in the test.
  4. Benni Mack commented on patch set 1 07/06/16, 12:03

    AbstractWidgetViewHelperTest.php:18 Reply

    not in my installation... just updated master and it's there. can you recheck?
  5. Markus Klein commented on patch set 1 07/06/16, 12:10

    AbstractWidgetViewHelperTest.php:18 Reply

    Can confirm benni's finding. All good here.
  6. Christian Kuhn commented on patch set 1 07/06/16, 12:13

    AbstractWidgetViewHelperTest.php:18 Reply

    hmm. ignore my comment. sry 4 fuzz.
  7. Benni Mack voted on patch set 1 CR +2 V +2 07/06/16, 13:28

  8. Gerrit merged patch set 1 07/06/16, 13:28