Review TYPO3_6-2 Merged

48781[BUGFIX] Field is not added to TCA if part of fieldname exists

Markus Klein CR +2 V +2 Easy +19 −2 updated 07/07/16, 19:42

Commit message

Explode current showitem and check if new field is already
available instead of using a wrong strpos check.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 8

  1. Markus Klein uploaded patch set 1 07/02/16, 21:55

  2. Markus Klein commented on patch set 1 07/02/16, 21:57

    Please review again, it's a manual cherry-pick.
  3. Wouter Wolters commented on patch set 1 CR -1 07/05/16, 07:59

    test fails. -'fieldA, fieldB, fieldC;labelC, --palette--;;paletteC, fieldC1, fieldD, fieldD1, field' +'fieldA, fieldB, fieldC;labelC;paletteC;specialC, fieldC1, fieldD, fieldD1, field'
  4. Markus Klein commented on patch set 1 07/05/16, 08:41

    Ah, the generated TCA is different in 6.2
  5. Wouter Wolters uploaded patch set 2 07/07/16, 18:41

  6. Wouter Wolters commented on patch set 2 CR +1 V +1 07/07/16, 18:42

    Corrected the test.
  7. Markus Klein commented on patch set 2 CR +2 V +2 07/07/16, 19:41

    Thanks Wouter!
  8. Gerrit merged patch set 2 07/07/16, 19:42