48788[BUGFIX] Allow URL path segments like "typo3"
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Nicole Hummel +1
-
Verified V +2
- Markus Klein +2
- Nicole Hummel +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1420
-
Mathias Brodala uploaded patch set 1 07/04/16, 14:18
-
TYPO3com voted on patch set 1 V +1 07/04/16, 14:24 Completed build in 05m 51s on Mon, 4 Jul, 04:24 PM Test Summary: 9649 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-428
-
Helmut Hummel commented on patch set 1 07/04/16, 20:26
I don't understand how this should help for pages on top level named "typo3" -
Helmut Hummel commented on patch set 1 07/04/16, 20:34
ok, got it now :) -
Nicole Hummel updated the commit message in patch set 2 07/16/16, 12:59
-
Nicole Hummel voted on patch set 2 CR +1 V +1 07/16/16, 12:59
-
TYPO3com voted on patch set 2 V -1 07/16/16, 13:15 Completed build in 16m 02s on Sat, 16 Jul, 03:15 PM Test Summary: 9767 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-992
-
Wouter Wolters updated the commit message in patch set 3 07/16/16, 13:22
-
TYPO3com voted on patch set 3 V -1 07/16/16, 13:40 Completed build in 18m 21s on Sat, 16 Jul, 03:40 PM Test Summary: 18852 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-993
-
TYPO3com commented on patch set 2 07/16/16, 13:47 Completed build in 1h 04m 05s on Sat, 16 Jul, 03:47 PM Test Summary: 10394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-992
-
TYPO3com voted on patch set 2 V +1 07/16/16, 13:58 Completed build in 2h 02m 58s on Sat, 16 Jul, 03:58 PM Test Summary: 19290 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-992
-
TYPO3com voted on patch set 3 V +1 07/16/16, 14:05 Completed build in 1h 01m 24s on Sat, 16 Jul, 04:05 PM Test Summary: 19290 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-993
-
Nicole Hummel voted on patch set 3 CR +1 V +1 08/05/16, 09:49
-
Stefan Neufeind voted on patch set 3 CR +1 08/18/16, 13:39
-
Markus Klein commented on patch set 3 08/18/16, 14:25
Did you test whether this rule still works as intended if the TYPO3 instance is situated in a subfolder of docroot? -
Stefan Neufeind commented on patch set 3 CR 0 08/18/16, 14:32
Since we don't have a RewriteBase set, do we maybe need to use %{ENV:CWD} then? -
Markus Klein commented on patch set 3 08/18/16, 14:48
Actually it should work since the folder-prefix is stripped and reapplied automatically. I just wonder why we didn't anchor the regex first place. Maybe there was some reason, but I can't remember. -
Markus Klein commented on patch set 3 CR +2 V +2 08/18/16, 15:34
Seems to work as intended. -
Gerrit merged patch set 3 08/18/16, 15:34
-
Markus Klein commented on patch set 4 08/18/16, 15:34
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 0f24636c3d8400c7c05ff9bdf5e7d0e5165a2830