Review main Merged

4881[TASK] Trivial: bad phpDoc format in tslib_feUserAuth

Dmitry Dulepov CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

phpDoc format does not conform to TYPO3 CGL in class
tslib_feUserAuth, function getCookieName(). Lines need to be
rearranged, proper letter case set.

Review

  • Code review CR +2
    • Dmitry Dulepov +2
    • Xavier Perseguers +2
    • Björn Pedersen +1
  • Verified V +2
    • Dmitry Dulepov +2
    • Xavier Perseguers +2

Issues 1

Files 1

Review log 7

  1. Björn Pedersen commented on patch set 1 09/09/11, 13:41

    Looks good to me, but someone else must approve
  2. Dmitry Dulepov commented on patch set 1 V 0 09/09/11, 13:41

    by team member; Looks good to me, approved
  3. Dmitry Dulepov commented on patch set 1 09/09/11, 13:41

    Yet another thing. RealURL sometimes needs to recalculate cHash. I am unsure if that new function is compatible with RealURL. Unlike extensions, RealURL has no idea about any internal logic. It always uses all valid parameters for calculating cHash. This patch needs to be tested with RealURL because adjusting RealURL algorithms for this new functionality would not be possible (it does not have required knowledge). I am not saying it would not work, I am only saying that it has to be tested. I suggest using fixed & normal postVars with 3 parameters and last two of them marked as "optional". If cHash is calculated correctly, than all is ok.
  4. Xavier Perseguers commented on patch set 1 V 0 09/09/11, 13:41

    by team member; Looks good to me, approved
  5. Xavier Perseguers merged patch set 1 09/09/11, 13:41

  6. Mr. Jenkins commented on patch set 1 09/09/11, 13:41

  7. Dmitry Dulepov commented on patch set 1 09/09/11, 13:41

    Please, ignore the last comment. No idea how it went here.